Skip to content

Include mbed_assert.h in Queue #13306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

AGlass0fMilk
Copy link
Member

Summary of changes

Include mbed_assert.h in Queue.

Impact of changes

Migration actions required

Before, building an application using rtos::Queue would encounter the following compiler error:

[Error] Queue.h@80,9: there are no arguments to 'MBED_ASSERT' that depend on a template parameter, so a declaration of 'MBED_ASSERT' must be available [-fpermissive]

This was because mbed_assert.h was not being included and so MBED_ASSERT was locally undefined.

I encountered this compile error using mbed-cli and GCC with mbed-os-6.1.0

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 17, 2020
@ciarmcom ciarmcom requested review from a team July 17, 2020 17:00
@ciarmcom
Copy link
Member

@AGlass0fMilk, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jul 20, 2020
@mergify
Copy link

mergify bot commented Jul 20, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

evedon
evedon previously approved these changes Jul 20, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2020

@AGlass0fMilk Can you rebase and we restart CI?

@AGlass0fMilk AGlass0fMilk force-pushed the queue-include-assert branch from 11eb092 to 374fed6 Compare July 21, 2020 09:30
@mergify mergify bot dismissed stale reviews from 0xc0170 and evedon July 21, 2020 09:31

Pull request has been modified.

@AGlass0fMilk
Copy link
Member Author

@AGlass0fMilk Can you rebase and we restart CI?

@0xc0170 Rebased with master

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2020

The license check is not related, I am looking at it..

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 23, 2020

@AGlass0fMilk Can you rebase, travis should be fixed, we will start CI asap

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 29, 2020

Any update with rebase?

@AGlass0fMilk AGlass0fMilk force-pushed the queue-include-assert branch from 374fed6 to e77cdff Compare July 30, 2020 15:23
@AGlass0fMilk
Copy link
Member Author

@0xc0170 Rebased

@adbridge
Copy link
Contributor

adbridge commented Aug 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 7, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 3daee1d into ARMmbed:master Aug 10, 2020
@mergify mergify bot removed the ready for merge label Aug 10, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants