-
Notifications
You must be signed in to change notification settings - Fork 3k
Include mbed_assert.h in Queue #13306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AGlass0fMilk, thank you for your changes. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
@AGlass0fMilk Can you rebase and we restart CI? |
11eb092
to
374fed6
Compare
Pull request has been modified.
@0xc0170 Rebased with master |
The license check is not related, I am looking at it.. |
@AGlass0fMilk Can you rebase, travis should be fixed, we will start CI asap |
Any update with rebase? |
374fed6
to
e77cdff
Compare
@0xc0170 Rebased |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Include
mbed_assert.h
in Queue.Impact of changes
Migration actions required
Before, building an application using
rtos::Queue
would encounter the following compiler error:This was because
mbed_assert.h
was not being included and soMBED_ASSERT
was locally undefined.I encountered this compile error using mbed-cli and GCC with mbed-os-6.1.0
Documentation
None
Pull request type
Test results
Reviewers