Support to BlueNRG_2 BLE component #13246

apalmieriGH · 2020-07-08T08:06:41Z

Summary of changes

Add support to BlueNRG_2 BLE Component

Documentation

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan- @MarceloSalazar @avilei @jeromecoutant @LMESTM

avilei · 2020-07-08T08:39:26Z

Grazie Andrea! Ciao Antonio From: Andrea Palmieri <[email protected]> Sent: Wednesday, July 8, 2020 10:07 AM To: ARMmbed/mbed-os <[email protected]> Cc: Antonio VILEI <[email protected]>; Mention <[email protected]> Subject: [ARMmbed/mbed-os] Support to BlueNRG_2 BLE component (#13246) Summary of changes Add support to BlueNRG_2 BLE Component Documentation

…

________________________________ Pull request type [] Patch update (Bug fix / Target update / Docs update / Test update / Refactor) [X] Feature update (New feature / Functionality change / New API) [] Major update (Breaking change E.g. Return code change / API behaviour change)

________________________________ Test results [] No Tests required for this change (E.g docs only update) [X] Covered by existing mbed-os tests (Greentea or Unittest) [] Tests / results supplied as part of this PR

________________________________ Reviewers @pan-<https://github.com/pan-> @MarceloSalazar<https://github.com/MarceloSalazar> @avilei<https://github.com/avilei> @jeromecoutant<https://github.com/jeromecoutant> @LMESTM<https://github.com/LMESTM>

________________________________ You can view, comment on, or merge this pull request online at: #13246 Commit Summary * Add support to BlueNRG_2 BLE component * Merge remote-tracking branch 'upstream/master' File Changes * A components/BLE/COMPONENT_BlueNRG_2/BlueNrg2HCIDriver.cpp<https://github.com/ARMmbed/mbed-os/pull/13246/files#diff-73a308bd6793189a639cc1f6c4ac8fa7> (532) * A components/BLE/COMPONENT_BlueNRG_2/README.md<https://github.com/ARMmbed/mbed-os/pull/13246/files#diff-ca102807796883d4c8e2629175d60a2a> (108) * A components/BLE/COMPONENT_BlueNRG_2/mbed_lib.json<https://github.com/ARMmbed/mbed-os/pull/13246/files#diff-b6f32dbd795cd0324c54728c2de2955a> (15) Patch Links: * https://github.com/ARMmbed/mbed-os/pull/13246.patch * https://github.com/ARMmbed/mbed-os/pull/13246.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#13246>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADUCNIZGXBMM4Y72FZ5R4T3R2QSKBANCNFSM4OUJQUBA>.

ciarmcom · 2020-07-08T09:00:33Z

@apalmieriGH, thank you for your changes.
@avilei @pan- @jeromecoutant @MarceloSalazar @LMESTM @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

jeromecoutant · 2020-07-08T13:38:01Z

components/BLE/COMPONENT_BlueNRG_2/README.md

+|Module Name|Processor Name|Bluetooth compliance|Status|Used in shields & boards|Link|
+|-------------|-----------|-----|-|-|-|
+|SPBTLE-RF    |BlueNRG-MS (network processor) |v4.1 |Not recommended for new designs             |X-NUCLEO-IDB05A1, DISCO-L475VG-IOT01A, DISCO-L562QE | https://www.st.com/en/wireless-transceivers-mcus-and-modules/spbtle-rf.html |
+|BlueNRG-M0   |BlueNRG-MS (network processor) |v4.2 |Active (included in ST's Longevity Program) |X-NUCLEO-IDB05A2 (coming soon) | https://www.st.com/en/wireless-transceivers-mcus-and-modules/bluenrg-m0.html |


Table in COMPONENT_BlueNRG_MS/README.md has to be updated ?

I would suggest to update and align the table in COMPONENT_BlueNRG_MS/README.md as well.

jeromecoutant · 2020-07-08T13:38:14Z

components/BLE/COMPONENT_BlueNRG_2/README.md

+
+In order to use this library with X-NUCLEO-BNRG2A1, you need to update the firmware of the BLUENRG-M2SP BLE module mounted on that expansion board as described in the following page:
+
+[TODO BlueNRG-2](https://os.mbed.com/components/X-NUCLEO-BNRG2A1/)


Link doesn't work

It is just a bookmark for now.

jeromecoutant · 2020-07-08T13:39:06Z

components/BLE/COMPONENT_BlueNRG_2/README.md

+
+Bluetooth Low Energy Nucleo Expansion Board:
+
+https://os.mbed.com/components/X-NUCLEO-BNRG2A1/


Link doesn't work

Just a bookmark for now.

jeromecoutant · 2020-07-08T14:43:29Z

components/BLE/COMPONENT_BlueNRG_2/BlueNrg2HCIDriver.cpp

+    virtual void initialize()
+    {
+        // Setup the spi for 8 bit data, low clock polarity,
+        // 2-edge phase, with an 1MHz clock rate (rate to be checked)


Avoid comment like "to be checked" :-)

None "to be done" in the code 💯

jeromecoutant · 2020-07-08T14:52:14Z

components/BLE/COMPONENT_BlueNRG_2/BlueNrg2HCIDriver.cpp

+    uint16_t spiWrite(uint8_t type, const uint8_t *data, uint16_t data_length)
+    {
+        static const uint8_t header_master[] = { 0x0a, 0x00, 0x00, 0x00, 0x00 };
+        uint8_t header_slave[5];//  = { 0xaa, 0x00, 0x00, 0x00, 0x00 };


comment to remove ?

jeromecoutant · 2020-07-08T15:02:09Z

components/BLE/COMPONENT_BlueNRG_2/README.md

+|Settings|Pin 1|Pin 2|Pin 3|
+|--------|-----|-----|-----|
+|**D3**  |Open |Short|Short|
+|**D13** |Short|Short|Open |
+
+In case you change the default configuration, then you also have to configure this library to use pin **D13** to drive the SPI clock.
+To this aim you need to update your local mbed_app.json file with:
+
+```
+    "target_overrides": {
+        "XXXX": {
+            "bluenrg_2.SPI_SCK": "D13"
+        },
+```
+
+If you use pin **D13** for the SPI clock, please be aware that on some STM32 Nucleo boards you may **not** drive the LED,
+otherwise you will get a conflict: the LED on STM32 Nucleo boards is connected to pin **D13**.
+
+Referring to the current list of tested platforms (see [X-NUCLEO-BNRG2A1](https://os.mbed.com/components/X-NUCLEO-BNRG2A1/) page),
+the patch is required for
+- [ST-Nucleo-F103RB](https://developer.mbed.org/platforms/ST-Nucleo-F103RB/)
+- [ST-Nucleo-F411RE](https://developer.mbed.org/platforms/ST-Nucleo-F411RE/)
+- [ST-Nucleo-F446RE](https://developer.mbed.org/platforms/ST-Nucleo-F446RE/)
+- [FRDM-K64F](https://developer.mbed.org/platforms/FRDM-K64F/)
+


Is this part valid ? tested ?

Not tested, yet. But the behavior should be the same as for X-NUCLEO-IDB05A1 (BlueNRG_MS component). Anyway, I'll update/rephrase the readme accordingly.

0xc0170

Why there is no BlueNrg2HCIDriver.h , but all is in BlueNrg2HCIDriver.cpp ?

0xc0170 · 2020-07-09T13:22:56Z

components/BLE/COMPONENT_BlueNRG_2/BlueNrg2HCIDriver.cpp

+#include "hci_mbed_os_adaptation.h"
+
+// rtos
+#include "Thread.h"


lets use prefixes like on line 22, rtos/header.h

The structure of the folder is the same as components/BLE/COMPONENT_BlueNRG_MS

Pull request has been modified.

0xc0170 · 2020-07-10T07:24:17Z

Please remove merge commit 572b384 and rebase instead. We will start CI asap

0xc0170 · 2020-07-16T13:44:29Z

@apalmieriGH I am reviewing, and noticed there are merge commits still. Would you be able to rebase? Or if not , I can fetch the branch and try to clean the history (it should be linear to show only changes related to this branch).

0xc0170

Waiting for the rebase to clean up the history

Pull request has been modified.

apalmieriGH · 2020-07-17T10:31:33Z

@0xc0170 tried to rebase. Could it work now?

0xc0170 · 2020-07-27T09:54:47Z

@ARMmbed/mbed-os-pan Please review

Pull request has been modified.

Signed-off-by: Andrea PALMIERI <[email protected]>

also correctly set unused addres to 0s as required by spec

Signed-off-by: Andrea PALMIERI <[email protected]>

0xc0170 · 2020-12-16T15:09:09Z

CI started

mbed-ci · 2020-12-16T17:06:09Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

0xc0170 · 2020-12-17T14:36:57Z

I'll squash merge this, there are lot of readme updates, one commit looks better for this update.

ciarmcom requested review from avilei, jeromecoutant, LMESTM, MarceloSalazar, pan- and a team July 8, 2020 09:00

ciarmcom added the needs: review label Jul 8, 2020

jeromecoutant reviewed Jul 8, 2020

View reviewed changes

0xc0170 previously requested changes Jul 9, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review labels Jul 9, 2020

apalmieriGH force-pushed the master branch from 66e4b44 to 32ea6a6 Compare July 10, 2020 09:34

0xc0170 previously requested changes Jul 16, 2020

View reviewed changes

apalmieriGH force-pushed the master branch from 0eb9ccd to 6566fc3 Compare July 17, 2020 10:29

0xc0170 previously approved these changes Jul 27, 2020

View reviewed changes

mergify bot added the needs: CI label Jul 27, 2020

0xc0170 added needs: review and removed needs: CI needs: work labels Jul 27, 2020

apalmieriGH force-pushed the master branch from 6566fc3 to 38f198a Compare July 31, 2020 12:46

apalmieriGH and others added 11 commits December 14, 2020 15:28

Add binary for updating BlueNRG_2 FW with NUCLEO-F401RE

6f29ea3

Signed-off-by: Andrea PALMIERI <[email protected]>

Add BlueNRG-2 FW Image

93aefa6

Signed-off-by: Andrea PALMIERI <[email protected]>

Update README

f5f3a4e

Signed-off-by: Andrea PALMIERI <[email protected]>

Move outside binaries for BlueNRG_2 FW update

dad2b25

Signed-off-by: Andrea PALMIERI <[email protected]>

Add pics for BlueNRG_2 FW update description

caf5f27

Signed-off-by: Andrea PALMIERI <[email protected]>

Update README

76f6090

Signed-off-by: Andrea PALMIERI <[email protected]>

Fix broken links in README

7fbc9ad

Signed-off-by: Andrea PALMIERI <[email protected]>

rpa swap workaround for bluenrg2

7b8fa1c

also correctly set unused addres to 0s as required by spec

Add CMakeLists file

4fe8671

Signed-off-by: Andrea PALMIERI <[email protected]>

Update README

b28d1b4

Signed-off-by: Andrea PALMIERI <[email protected]>

Add BlueNRG_2 component entry

413c444

Signed-off-by: Andrea PALMIERI <[email protected]>

apalmieriGH force-pushed the master branch from ef1e559 to d763d09 Compare December 14, 2020 14:33

apalmieriGH added 2 commits December 14, 2020 15:53

Add extra configuration for NUCLEO_F446RE

46661ea

Signed-off-by: Andrea PALMIERI <[email protected]>

Update README

0da4f8a

Signed-off-by: Andrea PALMIERI <[email protected]>

apalmieriGH force-pushed the master branch from d763d09 to 0da4f8a Compare December 14, 2020 14:55

0xc0170 added needs: CI and removed needs: review labels Dec 16, 2020

paul-szczepanek-arm approved these changes Dec 16, 2020

View reviewed changes

0xc0170 approved these changes Dec 17, 2020

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Dec 17, 2020

0xc0170 merged commit ae4a53e into ARMmbed:master Dec 17, 2020

mergify bot removed the ready for merge label Dec 17, 2020

mbedmain added release-version: 6.7.0 Release-pending and removed release-type: feature Release-pending labels Jan 25, 2021


		In order to use this library with X-NUCLEO-BNRG2A1, you need to update the firmware of the BLUENRG-M2SP BLE module mounted on that expansion board as described in the following page:

		[TODO BlueNRG-2](https://os.mbed.com/components/X-NUCLEO-BNRG2A1/)


		Bluetooth Low Energy Nucleo Expansion Board:

		https://os.mbed.com/components/X-NUCLEO-BNRG2A1/

Support to BlueNRG_2 BLE component #13246

Support to BlueNRG_2 BLE component #13246

Uh oh!

Conversation

apalmieriGH commented Jul 8, 2020

Summary of changes

Documentation

Pull request type

Test results

Reviewers

Uh oh!

avilei commented Jul 8, 2020 via email

Uh oh!

ciarmcom commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apalmieriGH Jul 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jul 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 10, 2020

Uh oh!

0xc0170 commented Jul 16, 2020

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

apalmieriGH commented Jul 17, 2020

Uh oh!

0xc0170 commented Jul 27, 2020

Uh oh!

0xc0170 commented Dec 16, 2020

Uh oh!

mbed-ci commented Dec 16, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Dec 17, 2020

Uh oh!

Uh oh!

apalmieriGH Jul 9, 2020 •

edited

Loading

0xc0170 Jul 9, 2020 •

edited

Loading