tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accuracy #13174
Conversation
|
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Can you elaborate in the commit message about what is this fixing ?
I assume timeout_ms was a given number that would be upscaled to fit most of the platforms. This was failing some slower targets? Thus using frequency (where is this coming from, config?).
My proposal would be to have details in the commit message so we do not need to read the code to find out where all these numbers come from and how they fix the issue (timeout_ms vs accuracy).
|
@jeromecoutant, thank you for your changes. |
…racy information Test is checking the exact time for watchdog, which is based on a non accurate clock... Correction is then taken into account clock information from API.
d40e31e to
4d7db01
Compare
done |
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Summary of changes
tests-mbed_timing_fpga_ci_test_shield-watchdog is sometimes failed with some boards.
Proposition is to use information from hal_watchdog_get_platform_features api
like for
https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbed_hal/watchdog_timing/main.cpp
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers