Skip to content

Reinstate post build hooks for legacy targets #13081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2020
Merged

Reinstate post build hooks for legacy targets #13081

merged 3 commits into from
Jun 10, 2020

Conversation

rwalton-arm
Copy link
Contributor

@rwalton-arm rwalton-arm commented Jun 8, 2020 •
edited
Loading

Summary of changes

This patch reinstates the post build hooks for NRF51, Teensy and MTS targets.

The online compiler requires these post build hooks.

Fixes the following reported issue in the online compiler.
https://forums.mbed.com/t/suddenly-getting-error-target-not-supported-missing-post-build-hook/8750

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Verified LPC4088 and MTS_DOT in the online compiler manually.
NRF51 (microbit) verified in hardhat tests
https://hardhat.test.mbed.com/#/out_of_box/micro_bit/2020-06-08T02:59:57.000Z

Reviewers

@Patater

@ciarmcom ciarmcom requested review from Patater and a team June 8, 2020 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2020

@rwalton-arm, thank you for your changes.
@Patater @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Patater
Patater approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 10, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten.

@0xc0170 0xc0170 merged commit 93be66e into master Jun 10, 2020
@mergify mergify bot removed the ready for merge label Jun 10, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 deleted the rw-post-build-hooks branch October 5, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rwalton-arm @ciarmcom @0xc0170 @mbed-ci @Patater @adbridge