Skip to content

Add support for the Telit ME310 module #13009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add support for the Telit ME310 module #13009

merged 1 commit into from
Jun 17, 2020

Conversation

trowbridgec
Copy link

@trowbridgec trowbridgec commented May 22, 2020 •
edited
Loading

Summary of changes

This PR adds framework support for the Telit ME310 Cat-M1/NB-IoT module (both using LwIP/PPP and the module's built-in AT command-based IP stack).

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@trowbridgec
Copy link
Author

@maclobdell @ARMmbed/team-embeddedplanet

@mergify mergify bot added the needs: work label May 22, 2020
@trowbridgec trowbridgec force-pushed the add-telit-me310-driver branch from df708b4 to 2261dd0 Compare May 22, 2020 19:51
@ciarmcom ciarmcom requested review from a team May 23, 2020 01:00
@ciarmcom
Copy link
Member

@trowbridgec, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes May 25, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels May 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 25, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

kivaisan
kivaisan reviewed May 28, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2020

Set back to review. @trowbridgec Can you review the latest comments?

@trowbridgec
Copy link
Author

@0xc0170 sorry for the delay! I'll get on this ASAP.

@adbridge
Copy link
Contributor

@trowbridgec isn't this just adding a new target so should be a patch update ?

@mergify mergify bot dismissed 0xc0170’s stale review June 12, 2020 13:21

Pull request has been modified.

@trowbridgec trowbridgec force-pushed the add-telit-me310-driver branch from a59b6cd to 125f169 Compare June 12, 2020 13:22
@trowbridgec
Copy link
Author

@adbridge Actually, this is just adding support for a new cellular modem (not a new Mbed target). Should this be a patch update?

@adbridge
Copy link
Contributor

@trowbridgec if you're only adding support for interfaces that are already there then yes this would just be a patch :)

@trowbridgec
Copy link
Author

@adbridge Thanks! I'll edit the description.

@trowbridgec
Copy link
Author

@kivaisan Can you take another look at this PR? Thanks!

@trowbridgec
Copy link
Author

Anything else that needs cleaned up for this PR? @0xc0170 can you take another look? Thanks!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 16, 2020

CI restarted

@mergify mergify bot added needs: CI and removed needs: work labels Jun 16, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 16, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@farrenv farrenv mentioned this pull request Jun 16, 2020
Merged
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 17, 2020
@0xc0170 0xc0170 merged commit 95a3a30 into ARMmbed:master Jun 17, 2020
@mergify mergify bot removed the ready for merge label Jun 17, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kivaisan kivaisan kivaisan approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trowbridgec @ciarmcom @0xc0170 @mbed-ci @adbridge @kivaisan