Skip to content

Nuvoton: Refine more on watchdog HAL (5.15) #12970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2020
Merged

Nuvoton: Refine more on watchdog HAL (5.15) #12970

merged 4 commits into from
Jun 8, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented May 14, 2020

Summary of changes

This PR is backport of #12923 into Mbed OS 5.15.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 4 commits May 14, 2020 11:45
@ccli8
Nuvoton: Enlarge WDT reset delay to avoid premature WDT reset
b70b65c 
Consider the following factors to define WDT reset delay:
1. Cannot be too small. This is to avoid premature WDT reset in pieces of timeout cascading.
2. Cannot be too large. This is to pass Greentea reset_reason/watchdog_reset tests, which have e.g. 50~100 reset delay tolerance.
@ccli8
Nuvoton: Fix WDT feature report with clock frequency
2162aaa
@ccli8
Nuvoton: Fix failure to change WDT clock source
572bae3 
WDT clock source selection and its enablement bits are protected. Add unlock sequence before write to them.
@ccli8
Nuvoton: Change WDT clock source to LXT
3d1fd6a 
LIRC has 40%~50% error rate, so change WDT clock source to LXT from LIRC.

NOTE: NANO100 series just supports LIRC-clocked WDT.
@ciarmcom ciarmcom requested a review from a team May 14, 2020 05:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers May 15, 2020 08:28
@mergify mergify bot added needs: CI and removed needs: review labels May 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 3, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 9cac2f4 into ARMmbed:mbed-os-5.15 Jun 8, 2020
@mergify mergify bot removed the ready for merge label Jun 8, 2020
@ccli8 ccli8 deleted the nuvoton_5.15_watchdog_lxt branch June 9, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @andypowers