Skip to content

Cleaning up PinNames.h for SDP-K1 board. #12945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

Cleaning up PinNames.h for SDP-K1 board. #12945

merged 1 commit into from
May 12, 2020

Conversation

malavikasajikumar
Copy link
Contributor

@malavikasajikumar malavikasajikumar commented May 7, 2020 •
edited
Loading

Summary of changes

Added pin description comments to Arduino header pins and LED4.
Added I2C alias names.
Removed Oscillator and DEBUG pin definitions.
Use USBTX and USBRX for serial communications back to PC. Do not use STDIO_UART_TX and STDIO_UART_RX

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

SDP_K1_ARMC6_test.log
SDP_K1_GCC_ARM_test.log
SDP_K1_IAR_test.log
SDP_K1_ARMC6_mbed-os-tests-mbed_hal-sleep.log

Reviewers

@malavikasajikumar
Cleaning up PinNames.h for SDP-K1 board.
74bd04f 
Added pin description comments to Arduino header pins and LED4.
Added I2C alias names.
Removed Oscillator and DEBUG pin definitions.
Use USBTX and USBRX for serial communications back to PC. Do not use STDIO_UART_TX and STDIO_UART_RX
@ciarmcom ciarmcom requested a review from a team May 7, 2020 23:00
@ciarmcom
Copy link
Member

ciarmcom commented May 7, 2020

@malavikasajikumar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 8, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 6950e78 into ARMmbed:master May 12, 2020
@mergify mergify bot removed the ready for merge label May 12, 2020
@malavikasajikumar malavikasajikumar deleted the SDPK1-PinNames branch May 28, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malavikasajikumar @ciarmcom @0xc0170 @mbed-ci