Skip to content

Nuvoton: Fix watchdog reset failure on meeting Hard Fault #12896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

Nuvoton: Fix watchdog reset failure on meeting Hard Fault #12896

merged 1 commit into from
May 12, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 30, 2020

Summary of changes

This PR tries to fix watchdog reset ceases to be effective in interrupt-disabled scenario e.g. Hard Fault on Nuvoton targets.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: Fix watchdog reset failure on meeting Hard Fault
73824f0 
Original implementation doesn't enable watchdog reset in pieces of cascaded timeout, except the last one. This is to guarantee re-configuration can be in time, but in interrupt disabled scenario e.g. Hard Fault, watchdog reset can cease to be effective.

This change enables watchdog reset all the way of cascaded timeout. With trade-off, guaranteed watchdog reset function is more significant than re-configuration in time.
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from Ronny-Liu and a team April 30, 2020 09:00
@mergify mergify bot added needs: CI and removed needs: review labels May 4, 2020
@ccli8 ccli8 mentioned this pull request May 5, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 8, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit b376ee1 into ARMmbed:master May 12, 2020
@mergify mergify bot removed the ready for merge label May 12, 2020
@ccli8 ccli8 deleted the nuvoton_watchdog_hardfault branch May 13, 2020 01:25
@ccli8 ccli8 mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

Assignees
No one assigned
Labels
release-version: 6.0.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci