Skip to content

Musca-B1: Fix I2C pinmap array #12888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020

Conversation

GaborAbonyi
Copy link
Contributor

Summary of changes

Add closing element of the PinMap for I2C.

Impact of changes

Migration actions required

Documentation

N/A


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from ashok-rao and a team April 29, 2020 15:00
@ciarmcom
Copy link
Member

@GaborAbonyi, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-maintainers please review.

@mergify
Copy link

mergify bot commented Apr 30, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: review label Apr 30, 2020
0xc0170
0xc0170 previously approved these changes May 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2020

@GaborAbonyi There was an update, please rebase and we start testing

Change-Id: I00ba75d1a673a091cec9236c1e7dd71ac3994610
Signed-off-by: Gabor Abonyi <[email protected]>
@GaborAbonyi GaborAbonyi force-pushed the musca_b1_i2c_pinmap_fix branch from be5a886 to f7b7f45 Compare May 4, 2020 11:54
@mergify mergify bot dismissed 0xc0170’s stale review May 4, 2020 11:55

Pull request has been modified.

@GaborAbonyi
Copy link
Contributor Author

@0xc0170 Thanks! I wasn't sure if you take PRs while this PSA/TF-M transition is ongoing.

@0xc0170
Copy link
Contributor

0xc0170 commented May 6, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 6, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

Will be merged as soon as we have 6.0.0 beta1 released

@0xc0170 0xc0170 merged commit a7a6de2 into ARMmbed:master May 12, 2020
@mergify mergify bot removed the ready for merge label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants