Skip to content

Nuvoton: Add 'sectors' configuration option into targets.json #12802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 14, 2020

Summary of changes

This PR tries to add sectors configuration option into targets.json to enable bootloader for Nuvoton targets. Though arm_pack_manager/index.json has sectors available, Nuvoton's cmsis pack Nuvoton.NuMicro_DFP.pdsc doesn't have sectors entries and they must add into index.json manually. But not apply to all chip subfamilies. To support custom board which uses a different chip subfamily, add secotors into targets.json for all Nuvoton targets which enable Flash IAP.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

This change adds 'sectors' configuration option into 'targets.json' to enable bootloader for Nuvoton targets.
Though 'arm_pack_manager/index.json' has `sectors` available, Nuvoton's cmsis pack 'Nuvoton.NuMicro_DFP.pdsc' doesn't have 'sectors' entries and they must add into `index.json` manually. But not apply to all chip subfamilies.
To support custom board which uses a different chip subfamily, add 'secotors' into 'targets.json' for all Nuvoton targets which enable Flash IAP.
@ciarmcom ciarmcom requested a review from a team April 14, 2020 07:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit f0d04c8 into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
@ccli8 ccli8 deleted the nuvoton_sectors branch April 15, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants