Remove compatibility for Arm Compiler versions prior to 6.01.0050 #12708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the code prior to 6.01.0050 versions.
evedon
approved these changes
Mar 27, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
|
Test restarted (io serial device) |
0xc0170
approved these changes
Mar 30, 2020
|
Test restarted |
bulislaw
approved these changes
Mar 31, 2020
hugueskamba
reviewed
Mar 31, 2020
| @@ -1084,12 +1078,8 @@ extern "C" long PREFIX(_flen)(FILEHANDLE fh) | |||
| #if !defined(COMPONENT_SPE) || !defined(TARGET_TFM) | |||
|
|
|||
| #if !defined(__MICROLIB) | |||
| #if defined (__ARMCC_VERSION) && (__ARMCC_VERSION >= 6010050) | |||
There was a problem hiding this comment.
@evedon Wasn't #if defined (__ARMCC_VERSION) still required here?
There was a problem hiding this comment.
Well spotted. @rajkan01 we need a patch
There was a problem hiding this comment.
There was an already existing macro guard #ifdef __ARMCC_VERSION at https://github.com/ARMmbed/mbed-os/blob/master/platform/source/mbed_retarget.cpp#L1051, so it is not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removed the pre-processor directive __ARMCC_VERSION >= 6010050 and the code added for versions before 6.01.0050.
Impact of changes
Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.
Migration actions required
Use Arm Compiler 6
Documentation
Pull request type
Test results
Reviewers
@evedon