Skip to content

Tests: Remove support for ARM Compiler 5 #12706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

Tests: Remove support for ARM Compiler 5 #12706

merged 1 commit into from
Mar 27, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.

Impact of changes

Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.

Migration actions required

Use Arm Compiler 6.

Documentation

N/A

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond @evedon

@hugueskamba
Tests: Remove support for ARM Compiler 5
4318a07 
ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
evedon
evedon approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs: CI label Mar 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

Ci started

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 2736896 into ARMmbed:master Mar 27, 2020
@mergify
Copy link

mergify bot commented Mar 27, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Mar 27, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Mar 31, 2020
@hugueskamba hugueskamba deleted the hk_remove_armc5_support_tests branch June 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @0xc0170 @mbed-ci @evedon @adbridge