Drivers: Remove support for ARM Compiler 5 #12698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evedon
reviewed
Mar 25, 2020
drivers/MbedCRC.h
Outdated
| @@ -644,7 +644,7 @@ class MbedCRC { | |||
| } | |||
|
|
|||
| /* Check to see if we can do assembler optimizations */ | |||
| #if ((defined __GNUC__ || defined __clang__) && !defined __CC_ARM) && \ | |||
| #if ((defined __GNUC__ || defined __clang__)) && \ | |||
There was a problem hiding this comment.
One set of parenthesis can be removed.
|
@hugueskamba, thank you for your changes. |
ARM Compiler 5 is no longer actively supported and was superseded in Mbed OS by ARM Compiler 6.
66e537a to
e435738
Compare
evedon
approved these changes
Mar 26, 2020
|
Ci started |
Test run: FAILEDSummary: 2 of 6 test jobs failed Failed test jobs:
|
0xc0170
approved these changes
Mar 30, 2020
|
Restarted client test The test will be restarted later today |
|
Both restarted |
|
CI restarted |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ARM Compiler 5 is no longer actively supported and was superseded in
Mbed OS by ARM Compiler 6.
Impact of changes
Breaking change: The binary generated from ARM Compiler 5 cannot be relied on as support has been dropped.
Migration actions required
Use Arm Compiler 6.
Documentation
N/A
Pull request type
Test results
Reviewers
@evedon @LDong-Arm @rajkan01 @kjbracey-arm