Skip to content

Remove netsocket icetea tests and TCPServer #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2020
Merged

Remove netsocket icetea tests and TCPServer #12694

merged 2 commits into from
Apr 29, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Mar 25, 2020 •
edited
Loading

Summary of changes

Remove deprecated Netsocket Icetea tests and TCPServer class.

Impact of changes

  • Netsocket Icetea tests are removed
  • TCPServer class removed

Migration actions required

  • Use Netsocket Greentea tests (TESTS/netsocket)
  • TCPSocket can be used instead of TCPServer

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team March 25, 2020 08:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Mar 25, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

CI started

AnttiKauppila
AnttiKauppila previously approved these changes Mar 25, 2020
View reviewed changes
michalpasztamobica
michalpasztamobica approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you updated the unittests as well, that's great.
To my surprise I didn't find any documentation for TCPServer in mbed-os, neither in mbed-os-5-docs (other than one sentence explaining why TCPServer is not neccesary), os I guess this is complete :)

@kivaisan
Copy link
Contributor Author

kivaisan commented Mar 25, 2020 •
edited
Loading

I can see you updated the unittests as well, that's great.
To my surprise I didn't find any documentation for TCPServer in mbed-os, neither in mbed-os-5-docs (other than one sentence explaining why TCPServer is not neccesary), os I guess this is complete :)

I did look at documents as well and noticed TCPServer was not mentioned.

The only instance about removed stuff in documents I found from here: https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/tools/testing/testing_icetea.md#test-names but also here it is only referred as an example.

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 25, 2020
@kivaisan
Copy link
Contributor Author

tests-psa-its_ps failure probably isn't caused by this PR?

@mergify mergify bot added needs: CI and removed needs: work labels Mar 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

We will restart tests later today (CI issues being fixed one by one)

@mergify mergify bot added needs: work and removed needs: CI labels Mar 31, 2020
@mergify
Copy link

mergify bot commented Mar 31, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot dismissed stale reviews from 0xc0170 and AnttiKauppila April 1, 2020 06:03

Pull request has been modified.

@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 1, 2020

Rebased.

0xc0170
0xc0170 previously approved these changes Apr 3, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 9, 2020
@mergify
Copy link

mergify bot commented Apr 9, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 9, 2020

Rebased

@mergify mergify bot dismissed 0xc0170’s stale review April 9, 2020 08:21

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Apr 9, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Apr 9, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 9, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mergify
Copy link

mergify bot commented Apr 14, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Kimmo Vaisanen added 2 commits April 14, 2020 12:13
@kivaisan
Copy link
Contributor Author

Rebased

@mergify mergify bot dismissed 0xc0170’s stale review April 14, 2020 09:14

Pull request has been modified.

@kivaisan
Copy link
Contributor Author

@0xc0170 Could you please restart CI for this? Those earlier CI failures do not seem to relate to this PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 28, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 5
Build artifacts

@0xc0170 0xc0170 merged commit 4f9d21b into ARMmbed:master Apr 29, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2020 •
edited
Loading

I merged this accidentally as we are about to release beta1 today. I'll revert it now on master and create the same one for beta2, so nothing to do here, just a note to be aware. It will be on master later today again.

@0xc0170 0xc0170 mentioned this pull request Apr 29, 2020
Closed
@mergify mergify bot removed the ready for merge label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila left review comments

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kivaisan @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @michalpasztamobica