Skip to content

QSPI driver also acquires ownership upon initialization now. #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

QSPI driver also acquires ownership upon initialization now. #12680

merged 1 commit into from
Apr 2, 2020

Conversation

dustin-crossman
Copy link
Contributor

Summary of changes

This is the partial fix for the QSPI double init issue as described here: #12678
These changes prevent the QSPI driver from calling qspi_init twice (once during construction and once again on first use) as long as no other QSPI object acquires the object during that time.

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

GT Storage Tests:
GT_CY8CPROTO_062_4343W.log
Note: The general_filesystem test that failed also fails on master for the CY8CPROTO_062_4343W. On a CY8CKIT_062_WIFI_BT the general_filesystem test passed on this branch so the proto board failure appears unrelated.

Reviewers

@dustin-crossman dustin-crossman mentioned this pull request Mar 23, 2020
Closed
@ciarmcom ciarmcom requested review from a team March 24, 2020 00:00
@ciarmcom
Copy link
Member

@dustin-crossman, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 24, 2020
@dustin-crossman
Copy link
Contributor Author

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_greentea-test

Looks like this GT failure is unrelated: The tests-network-interface test (and only this one) failed on a NUCLEO_F429ZI.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

Test restarted

@adbridge
Copy link
Contributor

Those boards have been power cycled so will try running the CI again!

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@dustin-crossman
Copy link
Contributor Author

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_greentea-test

Looks unrelated again.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

We will restart tests later today

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

Test restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170 0xc0170 merged commit b7664fa into ARMmbed:master Apr 2, 2020
@mergify mergify bot removed the ready for merge label Apr 2, 2020
@mergify
Copy link

mergify bot commented Apr 2, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Apr 2, 2020
@adbridge adbridge added Backport Candidate and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Apr 2, 2020
@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@Mergifyio backport mbed-os-5.15

@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

@gpsimenos gpsimenos mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
Backport Candidate devices: cypress release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dustin-crossman @ciarmcom @0xc0170 @mbed-ci @adbridge