Cellular: Add deativation of context associated with profile #12589

fahimalavi · 2020-03-06T11:04:20Z

Summary of changes

Add deactivation of context associated with profile and fixing initialization phase

Impact of changes

Upon disconnect deactivation of context.

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Test report attached report_C030.zip

Reviewers

@MarceloSalazar

0xc0170 · 2020-03-06T11:34:46Z

I updated the title (add cellular: to identify the module changed here)

ciarmcom · 2020-03-06T12:00:34Z

@fahim-ublox, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2020-03-09T08:27:07Z

CI started

0xc0170 · 2020-03-09T09:02:23Z

Looks like unittest failed, CI will report soon the build logs

mbed-ci · 2020-03-09T09:03:03Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

0xc0170 · 2020-03-09T09:03:14Z

I found this in the logs:

[2020-03-09T08:32:15.341Z] CMakeFiles/features-cellular-framework-AT-at_cellularstack.dir/stubs/AT_CellularContext_stub.cpp.o:(.data.rel.ro._ZTVN4mbed18AT_CellularContextE[_ZTVN4mbed18AT_CellularContextE]+0x198): undefined reference to `mbed::AT_CellularContext::do_disconnect()'

pilotak · 2020-03-09T10:15:18Z

@fahim-ublox thanks a lot, i tested it and is up and running in 21 sec

pilotak · 2020-03-09T11:41:05Z

@fahim-ublox i just discovered that if i turn off the AT debug "cellular.debug-at": false i can't attach to network or it takes a lot of time due to a SYNC do_connect failed with -3004
without_AT_debug2.txt
without_AT_debug.txt

fahimalavi · 2020-03-09T11:42:44Z

I found this in the logs:

[2020-03-09T08:32:15.341Z] CMakeFiles/features-cellular-framework-AT-at_cellularstack.dir/stubs/AT_CellularContext_stub.cpp.o:(.data.rel.ro._ZTVN4mbed18AT_CellularContextE[_ZTVN4mbed18AT_CellularContextE]+0x198): undefined reference to `mbed::AT_CellularContext::do_disconnect()'

I suppose this failure is target independent. We don't have build system ready to build these target independent tests. The failure in unit test is due to I have made do_disconnect a protected method.

mudassar-ublox · 2020-03-12T07:23:26Z

Tested with UBLOX_C027 target and didn't face network attach failure with "cellular.debug-at": false configuration.
Attaching both mbed-os-example-cellular logs and MBED-OS-TESTS-NETSOCKET-UDP test logs with multiple iterations.

C027_Mbed_Cellular_Example_Logs.txt
C027_UDP_Test_Logs_.txt

0xc0170 · 2020-03-17T09:56:37Z

@ARMmbed/mbed-os-wan Please review ^^

AnttiKauppila · 2020-03-17T12:27:16Z

To fix the unittests, you need to add do_disconnect() function body to: https://github.com/ARMmbed/mbed-os/blob/master/UNITTESTS/stubs/AT_CellularContext_stub.cpp
It can be simply left empty as it should not break any test.
You can run this locally by calling 'mbed test --unittest' from mbed Os root folder

MarceloSalazar · 2020-03-17T13:35:54Z

@AnttiKauppila this file is maintained by Arm and it's not target dependant.
Can you please take the action to update the file?

kivaisan · 2020-03-19T09:32:39Z

@AnttiKauppila this file is maintained by Arm and it's not target dependant.
Can you please take the action to update the file?

This PR changes the visibility of the method so UT fix must come with this PR. And like Antti mentioned, just implement an empty function.

Pull request has been modified.

MarceloSalazar · 2020-03-20T17:39:56Z

@fahim-ublox thanks for the updates

@ARMmbed/mbed-os-maintainers can we re-run tests please?

fahimalavi · 2020-03-25T11:13:13Z

Apologies for delay as WFH. Now AT_CellularContext_stub.cpp has been updated

0xc0170 · 2020-03-25T11:24:03Z

CI restarted

mbed-ci · 2020-03-25T23:38:48Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

adbridge · 2020-03-27T15:09:20Z

Looks like unrelated ci issues, restarting

mbed-ci · 2020-03-27T23:25:21Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2020-03-30T14:48:23Z

test restarted (internal issue should be resolved)

0xc0170 · 2020-03-31T16:12:18Z

CI restarted

mbed-ci · 2020-04-01T06:51:54Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 5
Build artifacts

0xc0170 · 2020-04-01T08:14:19Z

@ARMmbed/mbed-os-wan Please review, ready for merge once approved

AnttiKauppila · 2020-04-01T08:52:54Z

@ARMmbed/mbed-os-maintainers Please go ahead and merge

0xc0170 · 2020-04-08T18:44:10Z

CI restarted

mbed-ci · 2020-04-08T21:44:35Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 6
Build artifacts

fahimalavi mentioned this pull request Mar 6, 2020

Ublox: Setting up APN problem #12544

Closed

0xc0170 changed the title ~~Added deativation of context associated with profile~~ Cellular: Add deativation of context associated with profile Mar 6, 2020

ciarmcom requested review from MarceloSalazar and a team March 6, 2020 12:00

ciarmcom added the needs: review label Mar 6, 2020

0xc0170 previously approved these changes Mar 9, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Mar 9, 2020

adbridge added needs: work and removed needs: CI labels Mar 12, 2020

AnttiKauppila previously approved these changes Mar 17, 2020

View reviewed changes

fahimalavi force-pushed the disconnect branch from 09a132a to 5364c42 Compare March 20, 2020 13:59

fahimalavi force-pushed the disconnect branch from 5364c42 to c6b6efc Compare March 25, 2020 11:09

0xc0170 added needs: CI and removed needs: work labels Mar 25, 2020

mergify bot added needs: work and removed needs: CI labels Mar 25, 2020

adbridge added needs: CI and removed needs: work labels Mar 27, 2020

0xc0170 added the release-version: 6.0.0-beta-1 label Apr 1, 2020

0xc0170 requested a review from a team April 1, 2020 08:13

0xc0170 added needs: review and removed needs: CI labels Apr 1, 2020

AnttiKauppila approved these changes Apr 1, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Apr 7, 2020

mergify bot added ready for merge and removed needs: CI labels Apr 8, 2020

0xc0170 merged commit 149235f into ARMmbed:master Apr 9, 2020

mergify bot removed the ready for merge label Apr 9, 2020

Cellular: Add deativation of context associated with profile #12589

Cellular: Add deativation of context associated with profile #12589

Uh oh!

Conversation

fahimalavi commented Mar 6, 2020 • edited by 0xc0170 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Documentation

Pull request type

Test results

Reviewers

Uh oh!

0xc0170 commented Mar 6, 2020

Uh oh!

ciarmcom commented Mar 6, 2020

Uh oh!

0xc0170 commented Mar 9, 2020

Uh oh!

0xc0170 commented Mar 9, 2020

Uh oh!

mbed-ci commented Mar 9, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Mar 9, 2020

Uh oh!

pilotak commented Mar 9, 2020

Uh oh!

pilotak commented Mar 9, 2020

Uh oh!

fahimalavi commented Mar 9, 2020

Uh oh!

mudassar-ublox commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 17, 2020

Uh oh!

AnttiKauppila commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarceloSalazar commented Mar 17, 2020

Uh oh!

kivaisan commented Mar 19, 2020

Uh oh!

MarceloSalazar commented Mar 20, 2020

Uh oh!

fahimalavi commented Mar 25, 2020

Uh oh!

0xc0170 commented Mar 25, 2020

Uh oh!

mbed-ci commented Mar 25, 2020

Test run: FAILED

Uh oh!

adbridge commented Mar 27, 2020

Uh oh!

mbed-ci commented Mar 27, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Mar 30, 2020

Uh oh!

0xc0170 commented Mar 31, 2020

Uh oh!

mbed-ci commented Apr 1, 2020

Test run: SUCCESS

Uh oh!

0xc0170 commented Apr 1, 2020

Uh oh!

AnttiKauppila commented Apr 1, 2020

Uh oh!

0xc0170 commented Apr 8, 2020

Uh oh!

mbed-ci commented Apr 8, 2020

Test run: SUCCESS

Uh oh!

Uh oh!

fahimalavi commented Mar 6, 2020 •

edited by 0xc0170

Loading

mudassar-ublox commented Mar 12, 2020 •

edited

Loading

AnttiKauppila commented Mar 17, 2020 •

edited

Loading