Remove the deprecated RawSerial, UARTSerial, Serial #12410

rajkan01 · 2020-02-11T17:03:04Z

Summary of changes

Removed RawSerial, Serial, UARTSerial deprecated classes.
Removed SerialBase deprecated APIs.

Impact of changes

Breaking change: RawSerial, Serial, UARTSerial classes have been deprecated since Mbed OS 6.0.0 and they are all removed now.

Migration actions required

Use BufferedSerial and UnbufferedSerial for serial communication.

Documentation

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @jamesbeyond

jamesbeyond · 2020-02-11T17:45:16Z

CI would be useful to see the impact of deprecating work 😃

0xc0170 · 2020-02-12T16:14:58Z

CI started

mbed-ci · 2020-02-12T17:41:47Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

Pull request has been modified.

0xc0170 · 2020-02-13T08:41:39Z

CI restarted

mbed-ci · 2020-02-13T09:20:47Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2020-02-13T13:06:03Z

There are still relevant failures for few targets

0xc0170 · 2020-02-24T13:07:20Z

I got one request, it's rather for the docs. I can't find the referenced docs PR here. As we update docs, can we quickly also update these classes to use other pins than USBTX/RX ?

There are lines like this UnbufferedSerial console(USBTX, USBRX); - we should rather use different pins, for console we provide config values to override or console retarget override. I can create a separate ticket.

0xc0170 · 2020-02-24T13:08:43Z

I marked this for beta-1

pan- · 2020-02-25T08:54:32Z

features/FEATURE_BLE/targets/TARGET_Maxim/MaximBLE.cpp

@@ -79,7 +79,6 @@ static DigitalIn _rts(BT_CTS);
 static DigitalIn _cts(BT_RTS);
 static DigitalIn _clk(BT_CLK);
 static DigitalOut _shutdown(BT_RST, 0);
-static Serial _uart(BT_TX, BT_RX, 115200);


This wasn't used. @ARMmbed/team-maximintegrated Is it ok for you ?

drivers/UnbufferedSerial.h

evedon · 2020-02-25T12:00:53Z

I got one request, it's rather for the docs. I can't find the referenced docs PR here. As we update docs, can we quickly also update these classes to use other pins than USBTX/RX ?

There are lines like this UnbufferedSerial console(USBTX, USBRX); - we should rather use different pins, for console we provide config values to override or console retarget override. I can create a separate ticket.

Please raise a separate ticket for this.

Pull request has been modified.

0xc0170 · 2020-02-26T15:40:34Z

CI started

mbed-ci · 2020-02-26T16:36:13Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

…ase attach API

evedon · 2020-03-03T13:28:34Z

CI fails due to compilation errors in nanostack-border-router. Ticket raised with mesh team.

Pull request has been modified.

adbridge · 2020-03-11T12:46:40Z

@rajkan01 @evedon What is the current status of this now? Should it be marked as needing a preceding PR ? Unlikely to meet alpha-3 ?

evedon · 2020-03-11T13:57:35Z

@rajkan01 @evedon What is the current status of this now? Should it be marked as needing a preceding PR ? Unlikely to meet alpha-3 ?

Internal ticket raised https://jira.arm.com/browse/IOTTHD-4010

bulislaw · 2020-03-13T11:55:59Z

We should try to get it merge soon as it causes a lot of warnings. Do we need to escalate?

rajkan01 · 2020-03-19T12:08:28Z

PelionIoT/sal-stack-nanostack-slip#14

0xc0170 · 2020-03-19T13:40:19Z

@rajkan01 The PR was merged, shall this be restarted ?

adbridge · 2020-03-20T11:05:44Z

CI started

mbed-ci · 2020-03-20T12:50:29Z

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 4
Build artifacts

evedon previously approved these changes Feb 11, 2020

View reviewed changes

mergify bot added the needs: CI label Feb 11, 2020

jamesbeyond previously approved these changes Feb 12, 2020

View reviewed changes

0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 12, 2020

0xc0170 previously approved these changes Feb 12, 2020

View reviewed changes

mergify bot added needs: work and removed needs: CI labels Feb 12, 2020

0xc0170 added needs: CI and removed needs: work labels Feb 13, 2020

mergify bot added needs: work and removed needs: CI labels Feb 13, 2020

0xc0170 added release-version: 6.0.0-alpha-3 and removed release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 labels Feb 24, 2020

rajkan01 requested a review from pan- February 24, 2020 16:47

pan- reviewed Feb 25, 2020

View reviewed changes

evedon previously requested changes Feb 25, 2020

View reviewed changes

drivers/UnbufferedSerial.h Outdated Show resolved Hide resolved

evedon added the BREAKING-CHANGE label Feb 25, 2020

0xc0170 added needs: review and removed needs: work labels Feb 25, 2020

mergify bot added needs: CI and removed needs: review labels Feb 25, 2020

mergify bot added needs: work and removed needs: CI labels Feb 26, 2020

Remove the deprecated RawSerial, UARTSerial, Serial class and SerialB…

df32091

…ase attach API

rajkan01 force-pushed the serial_remove_deprecate branch from 8b7caec to df32091 Compare March 3, 2020 13:32

evedon mentioned this pull request Mar 6, 2020

Sanitize Serial deprecation prints #12588

Closed

adbridge added release-version: 6.0.0-beta-1 needs: CI and removed release-version: 6.0.0-alpha-3 needs: work labels Mar 20, 2020

evedon approved these changes Mar 20, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Mar 20, 2020

adbridge merged commit d048cd4 into ARMmbed:master Mar 20, 2020

adbridge removed the ready for merge label Mar 20, 2020

0xc0170 mentioned this pull request Jul 27, 2020

Stream.h missing from mbed.h #13354

Closed

Remove the deprecated RawSerial, UARTSerial, Serial #12410

Remove the deprecated RawSerial, UARTSerial, Serial #12410

Uh oh!

Conversation

rajkan01 commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

jamesbeyond commented Feb 11, 2020

Uh oh!

0xc0170 commented Feb 12, 2020

Uh oh!

mbed-ci commented Feb 12, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Feb 13, 2020

Uh oh!

mbed-ci commented Feb 13, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Feb 13, 2020

Uh oh!

0xc0170 commented Feb 24, 2020

Uh oh!

0xc0170 commented Feb 24, 2020

Uh oh!

pan- Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evedon commented Feb 25, 2020

Uh oh!

0xc0170 commented Feb 26, 2020

Uh oh!

mbed-ci commented Feb 26, 2020

Test run: FAILED

Uh oh!

evedon commented Mar 3, 2020

Uh oh!

adbridge commented Mar 11, 2020

Uh oh!

evedon commented Mar 11, 2020

Uh oh!

bulislaw commented Mar 13, 2020

Uh oh!

rajkan01 commented Mar 19, 2020

Uh oh!

0xc0170 commented Mar 19, 2020

Uh oh!

adbridge commented Mar 20, 2020

Uh oh!

mbed-ci commented Mar 20, 2020

Test run: SUCCESS

Uh oh!

Uh oh!

rajkan01 commented Feb 11, 2020 •

edited

Loading