Disable restricted uart peripheral for NRF52840 #12407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing it has been found that all tests are skipped in the FPGA uart test on the NRF52840 target. This is caused by the following change: ARMmbed#12379 - Add STDIO UART as restricted for FPGA testing for all targets NRF targets have MUXed pins and mainly do not provide pin-maps. There are only dummy pin-maps for testing. These pin-maps hold only pins and do not specify the peripheral or function of the pin (always 0). Because of that if we restrict STDIO uart peripheral (0) all FPGA uart test cases will be skipped. To fix this we will remove this restriction for NRF52840. Restriction for testing the USBTX, USBRX pins is sufficient in this case.
fkjagodzinski
approved these changes
Feb 11, 2020
|
@mprse, thank you for your changes. |
fkjagodzinski
approved these changes
Feb 11, 2020
jamesbeyond
approved these changes
Feb 11, 2020
0xc0170
approved these changes
Feb 12, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
@0xc0170 I think that this CI failure is not related. |
|
Job restarted (internal fault) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
While testing it has been found that all tests are skipped in the FPGA uart test on the NRF52840 target.
This is caused by the following change: PR #12379
The above PR adds STDIO UART as restricted for FPGA testing for all targets.
NRF targets have MUXed pins and mainly do not provide pin-maps. There are only dummy pin-maps for testing.
These pin-maps hold only pins and do not specify the peripheral or function of the pin (always 0). Because of that if we restrict STDIO uart peripheral (0) all FPGA uart test cases will be skipped.
To fix this we will remove this restriction for NRF52840. Restriction for testing the USBTX, USBRX pins is sufficient in this case.
@fkjagodzinski Thanks for catching this!
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@0xc0170
@maciejbocianski @fkjagodzinski @jamesbeyond