Skip to content

Fix FAT filesystem ferror greentea test(SD Component) #12330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

Fix FAT filesystem ferror greentea test(SD Component) #12330

merged 2 commits into from
Jan 31, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 29, 2020 •
edited
Loading

Summary of changes

Disabling FAT filesystem ferror() test case as it's not supported by microlib.

Impact of changes

With these changes, the FAT file system greentea test passed.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@rajkan01
Fix sd filesystem greentea test
0d95f7e 
- Disable the ferror() API test case as its not supported by microlib
@ciarmcom ciarmcom requested review from evedon and a team January 29, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

SeppoTakalo
SeppoTakalo previously approved these changes Jan 29, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jan 29, 2020
@mergify mergify bot dismissed SeppoTakalo’s stale review January 29, 2020 17:25

Pull request has been modified.

@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit 370a936 into ARMmbed:master Jan 31, 2020
@mergify mergify bot removed the ready for merge label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo left review comments

@evedon evedon Awaiting requested review from evedon

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajkan01 @ciarmcom @jamesbeyond @mbed-ci @SeppoTakalo @kjbracey @0xc0170