Skip to content

Fix general filesystem greentea test #12316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

Fix general filesystem greentea test #12316

merged 2 commits into from
Jan 31, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 27, 2020 •
edited
Loading

Summary of changes

Microlib has not supported the following feature. It is not described in the documentation so confirmed this with ARM toolchain team.

  • fflush with the NULL file pointer
  • fread size Zero
  • The file is opened in an append mode, file position starts at the beginning

fflush and fread test cases are disabled for microlib and append test case modified to use fseek to move the file position to the end before fwrite.

Impact of changes

With these changes, general filesystem greentea test passed.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@rajkan01
Fix general filesystem greentea test
46a1f01 
ARM microlib is not supported below features
- fflush(NULL) return `-1` instead `0`
- fread with size parameter "Zero".
- if file opened in append mode, file postion starts from the beginning.
@mergify mergify bot added the needs: CI label Jan 27, 2020
@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit d99f128 into ARMmbed:master Jan 31, 2020
@mergify mergify bot removed the ready for merge label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I've fixed the version: Set to 6.0.0-alpha-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajkan01 @jamesbeyond @mbed-ci @0xc0170 @evedon @kjbracey