Skip to content

Tests: add missing mbed_trace.h multihoming header #12308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michalpasztamobica
Copy link
Contributor

Summary of changes

The printf calls were righteously changed to mbed_* in #12267, but the multihoming tests were missing an include mbed_trace. This might have not been noticed, because multihoming tests have specific setup, which is not available in nightly tests and most likely they never really get built. Fortunately, we have an internal CI running, which detected this omission.

Impact of changes

Multihoming tests compile without errors again.

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila
@AriParkkila
@tymoteuszblochmobica


@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnttiKauppila @AriParkkila @tymoteuszblochmobica @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jan 30, 2020
@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit e01aecc into ARMmbed:master Jan 31, 2020
@mergify mergify bot removed the ready for merge label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@michalpasztamobica michalpasztamobica deleted the multihoming_tests_trace_header branch January 31, 2020 13:00
@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I've fixed the version: Set to 6.0.0-alpha-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants