Skip to content

FPGA_CI_TEST_SHIELD : force all peripheral to be tested #12296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Some FPGA tests are testing all peripherals,
some are testing only 1, in order to save time I suppose.

Proposition is to be able to force all peripherals tests.

Impact of changes

With default configuration, there is no impact.
Impact comes only if user manually set FPGA_FORCE_ALL_PORTS macro.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@jeromecoutant jeromecoutant requested a review from mprse January 21, 2020 16:24
@ciarmcom ciarmcom requested review from a team January 21, 2020 18:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jan 24, 2020
@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor thing is that in the PWM test we could simply set timeout to 300 instead of setting timeout depending on FPGA_FORCE_ALL_PORTS symbol.

@kjbracey kjbracey merged commit 268096d into ARMmbed:master Jan 31, 2020
@mergify mergify bot removed the ready for merge label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@jeromecoutant jeromecoutant deleted the PR_FPGA_FORCE branch January 31, 2020 13:01
@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants