-
Notifications
You must be signed in to change notification settings - Fork 3k
Disable the cell AUX UART by default on EP_AGORA #12258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the cell AUX UART by default on EP_AGORA #12258
Conversation
@ARMmbed/team-embeddedplanet @maclobdell |
@ARMmbed/team-embeddedplanet |
f95e213
to
3ed710f
Compare
I pushed new changes which makes the port configuration ( |
@@ -114,7 +114,7 @@ nsapi_error_t ONBOARD_TELIT_ME910::init() | |||
// AT#PORTCFG=0 | |||
// Set command allows to connect Service Access Points to the external physical ports giving a great | |||
// flexibility. Examples of Service Access Points: AT Parser Instance #1, #2, #3, etc.. | |||
_at->at_cmd_discard("#PORTCFG", "=3"); | |||
_at->at_cmd_discard("#PORTCFG", "=", EP_AGORA_PORT_CONFIGURATION_VARIANT); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is missing a "%d".
Should be _at->at_cmd_discard("#PORTCFG", "=", "%d", EP_AGORA_PORT_CONFIGURATION_VARIANT);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right! Change added.
3ed710f
to
a21a006
Compare
@trowbridgec, thank you for your changes. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
We are investigating, CI tests are not executing, might restart CI |
All good, no execution of tests as this is target is not in the CI , thus skipped that stage. |
Summary of changes
Disables the auxiliary UART of the cell module on the
EP_AGORA
target by default. This was causing issues in thembed-os-example-pelion
example because the auxiliary UART is muxed with the default standard output UART. Therefore, if the auxiliary UART on the cell module is enabled, it has the undesired effect of receiving and attempting to parse the debug output as an AT command. When the parsing fails, it echoes back an error in the form:In the
mbed-os-example-pelion
example, this would result in undesired characters being received via standard input and subsequently undesired application behavior.So, the best path forward is to disable the auxiliary UART by default and let a user enable it if/when needed.
From the Telit ME910C1 AT command reference guide, for the
AT#PORTCFG
command (page 76) aVariant
value of0
enables the main cell module UART and 2 USB interfaces and does not enable the auxiliary UART (USIF1
):Therefore, changing from a
Variant
value of3
to a value of0
should effectively disable the auxiliary UART.NOTE: As stated in the AT command reference guide, this setting change does not take effect until the cell module is rebooted, but should only ever have to be configured once.
Impact of changes
The auxiliary UART of the cell module is disabled by default.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@linlingao