Skip to content

STM serial free: Set pin function only if pin is defined (not NC) #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

STM serial free: Set pin function only if pin is defined (not NC) #12237

merged 1 commit into from
Jan 15, 2020

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Jan 10, 2020

Summary of changes

This is a continuation of PR #12186 for issue #12172.

The previous fix was incomplete. It fixed the problem during initialization, but the same problem exists in serial_free() function.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mprse mprse mentioned this pull request Jan 10, 2020
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 10, 2020
@0xc0170 0xc0170 merged commit 88f48d2 into ARMmbed:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mprse @0xc0170 @mbed-ci @jeromecoutant