Skip to content

Kvstore tests #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2020
Merged

Kvstore tests #12206

merged 4 commits into from
Feb 21, 2020

Conversation

SeppoTakalo
Copy link
Contributor

Summary of changes

  • Add module tests for TDBStore
  • Add stub for moduletests that allow using of disk image instead of heap.
  • Extend storage tests with de-init test case

Documentation

no documentation updates required

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@VeijoPesonen

VeijoPesonen
VeijoPesonen reviewed Jan 8, 2020
View reviewed changes
VeijoPesonen
VeijoPesonen reviewed Jan 8, 2020
View reviewed changes
@ciarmcom ciarmcom requested review from VeijoPesonen and a team January 8, 2020 08:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 8, 2020

@SeppoTakalo, thank you for your changes.
@VeijoPesonen @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

Travis needs fixing, one line failed.

@adbridge
Copy link
Contributor

Travis needs fixing, one line failed.

@SeppoTakalo ^^^

@SeppoTakalo
Copy link
Contributor Author

Fixed and rebased.

adbridge
adbridge previously approved these changes Jan 23, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jan 23, 2020
@adbridge adbridge added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Jan 23, 2020
@adbridge
Copy link
Contributor

Ci started

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@adbridge
Copy link
Contributor

@SeppoTakalo Looks like possibly a genuine error:

[2020-01-23T15:04:14.526Z] CMake Error at CMakeLists.txt:189 (add_library):
[2020-01-23T15:04:14.526Z] Cannot find source file:
[2020-01-23T15:04:14.526Z]
[2020-01-23T15:04:14.526Z] stubs/mbed_assert_stub.c

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 6, 2020

jenkins-ci/unittests — Error

Is this PR still relevant and should be updated with a fix ?

@mergify mergify bot dismissed adbridge’s stale review February 19, 2020 10:45

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2020

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@SeppoTakalo
Copy link
Contributor Author

Rebased on top of master and fixed the remaining build issue on unittests.

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2020

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@SeppoTakalo
Copy link
Contributor Author

Two ST boards failed the test. I might have found a bug there..

@SeppoTakalo
Copy link
Contributor Author

It was out of memory issue with ST boards as they have very big sector sizes at the end of flash. Refactored the test case to use smaller RAM buffers.

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 4
Build artifacts

VeijoPesonen
VeijoPesonen approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 20, 2020

Ci started

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 5
Build artifacts

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 6
Build artifacts

@0xc0170 0xc0170 merged commit c520449 into ARMmbed:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@adbridge adbridge adbridge left review comments

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeppoTakalo @ciarmcom @0xc0170 @adbridge @mbed-ci @VeijoPesonen