Fixes for LPC55S69_NS TLS tests #12178
Conversation
847cd1f to
0adb47b
Compare
|
@tymoteuszblochmobica, thank you for your changes. |
| @@ -59,7 +59,7 @@ if (!isdefinedsymbol(MBED_BOOT_STACK_SIZE)) { | |||
| } | |||
|
|
|||
| define symbol __stack_size__ = MBED_BOOT_STACK_SIZE; | |||
| define symbol __heap_size__ = 0x4000; | |||
| define symbol __heap_size__ = 0x10000; | |||
There was a problem hiding this comment.
instead of this one, we should keep as it was and change to dynamic stack
define block HEAP with expanding size, alignment = 8, minimum size = __heap_size__ { };
this should fix it
There was a problem hiding this comment.
@0xc0170 . Just a side note - shouldn't we migrate all targets to use dynamic heap allocation with IAR? Do you know if anyone is working on this? If not then who could take care of this?
This could help us avoid a lot of issues of this kind.
There was a problem hiding this comment.
We should, but it's a lot of work :/
There was a problem hiding this comment.
@MarceloSalazar Can we bring this up again to partners to get this update to every target?
5a9a058 to
b40ab36
Compare
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Restarted Travis, should be ready for merge soon |
Fixed ESP8266 nullpointer dereference.
Incerased LPC55S69_NS heap in IAR linker script for TLS purpose.
Summary of changes
Issue for IAR echotest and echotest nonblock with calloc fail.
Problem solved after increasing heap for IAR linker script LPC55S69_cm33_core0_flash.icf
TLSSOCKET_CONNECT_INVALID fail caused by null pointer dereference in ESP8266.
ESP8266 tcp_open called with uninitialized socket IP adress and port - this is purpose of test
Then ATCmdParser calls on vsprintf with null.
This change returns with NSAPI_ERROR_PARAMETER if IP sting is null instead calling ATCmdParser and vsprintf.
Impact of changes
Migration actions required
Not needed.
Documentation
Not needed.
Pull request type
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Reviewers
@AnttiKauppila
@SeppoTakalo
@michalpasztamobica