-
Notifications
You must be signed in to change notification settings - Fork 3k
NRF52840: Use 2 region memory model for the ARM toolchain #12144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRF52840: Use 2 region memory model for the ARM toolchain #12144
Conversation
@hugueskamba, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@linlingao @desmond-blue @pan- I'm assuming that won't have any impact on Cordio? And I don't think we support softdevices on this board? |
I'll start ci on this pending an answer to @bulislaw 's question |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
@bulislaw No impact on Cordio, however I think this board is still supporting SoftDevice if configuring |
Looks like a CI issue so re-running |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
@adbridge The failure seems to have been caused by a lack of license for the IAR compiler. Can you please fix and re-run? Thanks. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Summary of changes
Use two memory region model to be able to compile with Microlib. This change should cause any regression when building with the standard C library and all existing tests should pass for all targets that use the scatter file modified in this PR.
Suppport for
uARM
toolchain has not been added as it is being deprecated. Building with Microlib will be possible after this PR is merged.After the two PRs are merged, one could test the targets that use the scatter file modified in this PR to ensure they run fine with Microlib by following the steps here to enable small library support for each target of interest.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers