Skip to content

NRF52840: Use 2 region memory model for the ARM toolchain #12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Use two memory region model to be able to compile with Microlib. This change should cause any regression when building with the standard C library and all existing tests should pass for all targets that use the scatter file modified in this PR.

Suppport for uARM toolchain has not been added as it is being deprecated. Building with Microlib will be possible after this PR is merged.

After the two PRs are merged, one could test the targets that use the scatter file modified in this PR to ensure they run fine with Microlib by following the steps here to enable small library support for each target of interest.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team December 19, 2019 16:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bulislaw
Copy link
Member

@linlingao @desmond-blue @pan- I'm assuming that won't have any impact on Cordio? And I don't think we support softdevices on this board?

@adbridge
Copy link
Contributor

I'll start ci on this pending an answer to @bulislaw 's question

@mbed-ci
Copy link

mbed-ci commented Dec 23, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@desmond-blue
Copy link
Contributor

@bulislaw No impact on Cordio, however I think this board is still supporting SoftDevice if configuring mbed_app.json correctly, it's just not a default option. Any other comments?

@adbridge
Copy link
Contributor

Looks like a CI issue so re-running

@mbed-ci
Copy link

mbed-ci commented Dec 24, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@hugueskamba
Copy link
Collaborator Author

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@adbridge The failure seems to have been caused by a lack of license for the IAR compiler. Can you please fix and re-run? Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 2, 2020
@0xc0170 0xc0170 merged commit a387985 into ARMmbed:master Jan 2, 2020
@hugueskamba hugueskamba deleted the hk-nrf52840-two-mem-region-model branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants