Skip to content

TESTS-MBED_HAL-COMMON_TICKERS no more executed #12138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2019
Merged

TESTS-MBED_HAL-COMMON_TICKERS no more executed #12138

merged 1 commit into from
Dec 27, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

During 15.5 release non regression tests, I could see that
TESTS-MBED_HAL-COMMON_TICKERS is no more executed

I think it was some copy paste error... :-)

Impact of changes

MBED_CONF_RTOS_PRESENT macro name corrected

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team December 19, 2019 10:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

fkjagodzinski
fkjagodzinski approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

mprse
mprse approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@adbridge adbridge added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 19, 2019
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 19, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@kjbracey
Copy link
Contributor

DISCO L475 serial error. CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@bulislaw bulislaw merged commit 4bdd573 into ARMmbed:master Dec 27, 2019
@jeromecoutant jeromecoutant deleted the PR_RTOS branch January 2, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeromecoutant @ciarmcom @adbridge @mbed-ci @kjbracey @fkjagodzinski @mprse @bulislaw @0xc0170