Add UDP ECHOTEST with connect/send/recv calls #12013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UDPSocket can be used also similar to TCPSocket using connect(), send() and recv() methods. This commit adds UDP ECHOTESTS which uses these methods instead of sendto() and recvfrom().
|
@kivaisan, thank you for your changes. |
0xc0170
approved these changes
Dec 9, 2019
michalpasztamobica
suggested changes
Dec 9, 2019
There was a problem hiding this comment.
@kivaisan , the code is fine (and smartly written, without copy&paste abuse), but I would like to request documentation update:
https://github.com/ARMmbed/mbed-os/blob/master/TESTS/netsocket/README.md
Updated README with new tests. |
|
CI started |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
AnttiKauppila
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
UDPSocket can be used also similar to TCPSocket using connect(), send() and recv() methods.
This commit adds UDP ECHOTESTs which uses these methods instead of sendto() and recvfrom().
Documentation
Pull request type
Test results
Reviewers
Release Notes
Summary of changes
Impact of changes
Migration actions required