Skip to content

DISCO_L4R9I: update default STMOD+ pin #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Tested with Quectel BG96 expansion board on STMOD+ connector of L4R9I DISCO board.

NB: mbed_app.json:

    "target_overrides": {
        "DISCO_L4R9I": {
            "stmod_cellular.provide-default": "true", 
            "target.components_add": [
                "STMOD_CELLULAR"
            ]
        }, 
target platform_name test suite result elapsed_time (sec) copy_method
DISCO_L4R9I-ARMC6 DISCO_L4R9I features-cellular-tests-api-cellular_device OK 50.26 default
DISCO_L4R9I-ARMC6 DISCO_L4R9I features-cellular-tests-api-cellular_information OK 24.05 default
DISCO_L4R9I-ARMC6 DISCO_L4R9I features-cellular-tests-api-cellular_network OK 66.38 default
DISCO_L4R9I-ARMC6 DISCO_L4R9I features-cellular-tests-api-cellular_sms OK 33.77 default
DISCO_L4R9I-ARMC6 DISCO_L4R9I features-cellular-tests-socket-udp OK 32.84 default

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@LMESTM

Release Notes

@ciarmcom ciarmcom requested a review from a team October 3, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it wrong before?

@jeromecoutant
Copy link
Collaborator Author

Was it wrong before?

Yes, not tested :-(

@jeromecoutant
Copy link
Collaborator Author

Please, don't start CI yet,
need to double check some new information I have
Thx

@jeromecoutant
Copy link
Collaborator Author

Hi
Correction is now OK.
(mistake was only with STMOD 2 and 3 pins, they are by default mapped to UART tx and rx,
whereas STMOD 4 pins is not mapped to UART rts)

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants