Skip to content

tools: add silent option to build #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2019
Merged

tools: add silent option to build #11457

merged 3 commits into from
Oct 21, 2019

Conversation

OPpuolitaival
Copy link
Contributor

@OPpuolitaival OPpuolitaival commented Sep 11, 2019 •
edited
Loading

Description

Add silent option in test.py and remove some not needed lines. Silent option is need to make CI build faster without logs. If build fails then it will be rebuild with verbose flag. Most of builds success, so then this save time

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge @madchutney

Release Notes

adbridge
adbridge requested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? It would be helpful if the PR description explained this.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 11, 2019

Why is this required? It would be helpful if the PR description explained this.

Title should provide be more descriptive plus as well the commits if we add/remove something (to answer there a question "why are these being added/removed").

@OPpuolitaival
Copy link
Contributor Author

Reason added

@0xc0170 0xc0170 requested a review from adbridge September 17, 2019 08:32
0xc0170
0xc0170 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing few not relevant things but LGTM

@0xc0170 0xc0170 changed the title Py params tools: add silent option to build Sep 17, 2019
adbridge
adbridge approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments for going forward though:

  1. PRs should generally contain only self contained fixes (or certainly in specific commits anyway). Do not mix new changes with general tidy ups etc
  2. Where is the new flag used ? Would be good to have something in the description covering what the knock on effects are of this?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

While this is in CI, please add details to the above review

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2019

@mark-edgeworth @madchutney Can you please review if all good here?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2019

It's set as refactor, thus 5.15 ?

@adbridge
Copy link
Contributor

adbridge commented Sep 27, 2019 •
edited
Loading

@mark-edgeworth @madchutney Can you please review if all good here?

@mark-edgeworth @madchutney bump...

mark-edgeworth
mark-edgeworth approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@mark-edgeworth
Copy link
Contributor

As this is test code @jamesbeyond may want to comment too...

jamesbeyond
jamesbeyond approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--silent already there is the build CLI, this make sense if we have the same CLI option for the test, especially it improves the test performance

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 1dac871 into ARMmbed:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@madchutney madchutney Awaiting requested review from madchutney

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OPpuolitaival @0xc0170 @mbed-ci @adbridge @mark-edgeworth @jamesbeyond