Cellular: Remove unnecessary local variables #11149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
suggested changes
Aug 1, 2019
| strncpy(pdp_type_str, "Non-IP", sizeof(pdp_type_str)); | ||
| pdp_type = NON_IP_PDP_TYPE; | ||
| } else if (modem_supports_ipv6 && modem_supports_ipv4) { | ||
| } else if (get_property(PROPERTY_IPV4V6_PDP_TYPE)) { |
There was a problem hiding this comment.
I guess it's good to add here that IPV4V6, but should also be IPV4 & IPV6 for single stack support.
There was a problem hiding this comment.
If a target doesn't mark as supported the IPV4V6 feature but it has IPV4 and IPV6 support, I think we should consider it as it doesnt support IPV4V6. Why else wouldnt have it set accordingly?
|
@mirelachirica, thank you for your changes. |
AriParkkila
approved these changes
Aug 2, 2019
SeppoTakalo
approved these changes
Aug 5, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary local variables.
Pull request type
Reviewers
@AriParkkila