Add CC3220SF_Launchxl to Mbed OS #11063

linlingao · 2019-07-17T18:21:17Z

Description

Add CC3220SF Launchxl support.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom · 2019-07-17T19:00:28Z

@linlingao, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

SeppoTakalo · 2019-07-17T20:26:10Z

New target support, @ARMmbed/mbed-os-hal Please review.

mbed-ci · 2019-07-23T11:57:57Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM

SeppoTakalo · 2019-07-23T12:23:57Z

@linlingao Please check the build failures.

CC3220SF ARM

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] Compile [  0.1%]: at24mac_s2lp.cpp

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] [Fatal Error] at24mac_s2lp.h@19,10: 'PinNames.h' file not found

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] Failed to build library

CC3220SF_LAUNCHXL ARM

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z] Build failures:

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]   * CC3220SF_LAUNCHXL::ARMC6::TESTS-MBED_HAL-PINMAP

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Building project pinmap (CC3220SF_LAUNCHXL, ARMC6)

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Scan: ARM

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Scan: pinmap

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Compile [100.0%]: main.cpp

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Link: pinmap

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol analogin_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol pwmout_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_cts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_rts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_rx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_tx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_clk_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_cs_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_miso_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_mosi_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol analogin_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol pwmout_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_cts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_rts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_rx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_tx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol spi_master_clk_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol spi_master_cs_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Error: L6218E: Undefined symbol spi_master_miso_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Error: L6218E: Undefined symbol spi_master_mosi_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Finished: 0 information, 3 warning and 10 error messages.

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]

…reating cc3220sf a target

mbed-ci · 2019-07-23T22:02:23Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

fkjagodzinski

Most of the HAL looks fine. Only the PWM is not complete.

targets/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/pwmout_api.c

targets/targets.json

mbed-ci · 2019-07-30T21:48:30Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

mbed-ci · 2019-07-31T19:07:22Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-test

cmonr · 2019-07-31T21:03:12Z

@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test-team That's odd.

Has it typically been the case where mbed-os-ci_cloud-client-test artifacts are not uploaded to S3, similar to the rest of the jobs?

SeppoTakalo · 2019-08-01T08:33:32Z

One server that Pelion Client tests against is down. We are investigating.

mbed-ci · 2019-08-01T16:23:29Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

SeppoTakalo · 2019-08-02T10:26:21Z

@ARMmbed/mbed-os-hal Missing PWM is now added, is this OK to go in?

linlingao · 2019-08-05T15:56:42Z

Please, please don't let this sit for too long... rebase PRs this big is painful...

linlingao · 2019-08-09T14:55:41Z

@ARMmbed/mbed-os-hal can you please review?

linlingao · 2019-08-13T14:18:35Z

@0xc0170 Is there anything I can do to move this along?

0xc0170 · 2019-08-13T14:37:29Z

@0xc0170 Is there anything I can do to move this along?

I keep this open and review tomorrow 👍

0xc0170

Cosmetic changes request. Otherwise looks good.

Lot of work in here, how was this tested? Adding new target should contain logs with tests run for all toolchains.

targets/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/trng_api.c

targets/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/objects.h

targets/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/gpio_irq_api.c

...s/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/TARGET_CC3220SF_LAUNCHXL/TargetConfiguration.ccxml

linlingao · 2019-08-14T16:16:27Z

@0xc0170 You can find status and links to Jira issues and test logs here. https://confluence.arm.com/display/CES/TI+Port+Milestones+and+Status (Arm internal link).

mbed-ci · 2019-08-16T08:57:39Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

linlingao · 2019-08-16T14:26:46Z

Can this be merged yet?

Add CC3220SF_Launchxl to Mbed OS

e74fbcd

linlingao mentioned this pull request Jul 17, 2019

Add CC3220SF LAUNCHXL to Mbed OS #11041

Closed

ciarmcom requested a review from a team July 17, 2019 19:00

ciarmcom added the needs: review label Jul 17, 2019

Added CC3220 related changes to tools

387bb66

SeppoTakalo requested a review from a team July 17, 2019 20:25

linlingao mentioned this pull request Jul 22, 2019

mBed OS support for CC3220SF launchpad #10951

Closed

SeppoTakalo approved these changes Jul 23, 2019

View reviewed changes

SeppoTakalo added the needs: CI label Jul 23, 2019

SeppoTakalo added needs: work and removed needs: CI needs: review labels Jul 23, 2019

Added missing pinmap definitions. Fixed target JSON config to avoid t…

2a06ae2

…reating cc3220sf a target

fkjagodzinski reviewed Jul 24, 2019

View reviewed changes

targets/TARGET_TI/TARGET_CC32XX/TARGET_CC3220SF/pwmout_api.c Outdated Show resolved Hide resolved

targets/targets.json Show resolved Hide resolved

Implement PWMOUT

eebe00b

Fix a build break with ARM compiler

c36980c

SeppoTakalo added needs: review needs: CI and removed needs: work labels Aug 1, 2019

SeppoTakalo removed the needs: CI label Aug 2, 2019

0xc0170 added the scope: new-target label Aug 14, 2019

0xc0170 requested changes Aug 14, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Aug 14, 2019

fkjagodzinski approved these changes Aug 14, 2019

View reviewed changes

Cosmetic changes to incorporate review feedback

cae7427

0xc0170 removed the needs: work label Aug 19, 2019

0xc0170 approved these changes Aug 19, 2019

View reviewed changes

0xc0170 added ready for merge release-version: 5.13.4 labels Aug 19, 2019

0xc0170 merged commit 101ae73 into ARMmbed:master Aug 19, 2019

0xc0170 removed the ready for merge label Aug 20, 2019

Add CC3220SF_Launchxl to Mbed OS #11063

Add CC3220SF_Launchxl to Mbed OS #11063

Uh oh!

Conversation

linlingao commented Jul 17, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Jul 17, 2019

Uh oh!

SeppoTakalo commented Jul 17, 2019

Uh oh!

mbed-ci commented Jul 23, 2019

Test run: FAILED

Uh oh!

SeppoTakalo commented Jul 23, 2019

Uh oh!

mbed-ci commented Jul 23, 2019

Test run: SUCCESS

Uh oh!

fkjagodzinski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mbed-ci commented Jul 30, 2019

Test run: FAILED

Uh oh!

mbed-ci commented Jul 31, 2019

Test run: FAILED

Uh oh!

cmonr commented Jul 31, 2019

Uh oh!

SeppoTakalo commented Aug 1, 2019

Uh oh!

mbed-ci commented Aug 1, 2019

Test run: SUCCESS

Uh oh!

SeppoTakalo commented Aug 2, 2019

Uh oh!

linlingao commented Aug 5, 2019

Uh oh!

linlingao commented Aug 9, 2019

Uh oh!

linlingao commented Aug 13, 2019

Uh oh!

0xc0170 commented Aug 13, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linlingao commented Aug 14, 2019

Uh oh!

mbed-ci commented Aug 16, 2019

Test run: SUCCESS

Uh oh!

linlingao commented Aug 16, 2019

Uh oh!

Uh oh!