Skip to content

Nordic NRF52832 cache ON #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Jul 1, 2019

Description

Nordic NRF52832 chip onboard instruction cache is turned ON to decrease execution time and improve performance.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm
@pan-

Release Notes

@ciarmcom ciarmcom requested review from kjbracey, pan- and a team July 1, 2019 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2019

@tymoteuszblochmobica, thank you for your changes.
@kjbracey-arm @pan- @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjbracey-arm @pan- does it require some clever flushing? Eg in bootloader cases?

@kjbracey
Copy link
Contributor

kjbracey commented Jul 2, 2019

I wouldn't think so. It's a cache integrated in to the non-volatile memory controller, and it's the same peripheral as used for programming, so I'd expect it to be self-aware. But that's me guessing without reading the manual. Someone should check.

@kjbracey
Copy link
Contributor

kjbracey commented Jul 2, 2019

Also, I understand the cache is turned on by SoftDevice anyway, so this will only affect non-SoftDevice builds. No idea how SoftDevice + bootloader interact though.

@0Grit
Copy link

0Grit commented Jul 2, 2019

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

@kjbracey-arm @pan- Before merging, all good with this change?

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't changed my mind. LGTM.

@0xc0170 0xc0170 merged commit b47064a into ARMmbed:master Jul 5, 2019
@0Grit
Copy link

0Grit commented Jul 5, 2019

Is the cache already on in NRF52840?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2019

Is the cache already on in NRF52840?

worth checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants