-
Notifications
You must be signed in to change notification settings - Fork 3k
Nordic NRF52832 cache ON #10933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nordic NRF52832 cache ON #10933
Conversation
@tymoteuszblochmobica, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjbracey-arm @pan- does it require some clever flushing? Eg in bootloader cases?
I wouldn't think so. It's a cache integrated in to the non-volatile memory controller, and it's the same peripheral as used for programming, so I'd expect it to be self-aware. But that's me guessing without reading the manual. Someone should check. |
Also, I understand the cache is turned on by SoftDevice anyway, so this will only affect non-SoftDevice builds. No idea how SoftDevice + bootloader interact though. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@kjbracey-arm @pan- Before merging, all good with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't changed my mind. LGTM.
Is the cache already on in NRF52840? |
worth checking! |
Description
Nordic NRF52832 chip onboard instruction cache is turned ON to decrease execution time and improve performance.
Pull request type
Reviewers
@kjbracey-arm
@pan-
Release Notes