-
Notifications
You must be signed in to change notification settings - Fork 3k
HAL I2C: adds missing DEVICE_I2C guards #10870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@maciejbocianski, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maciejbocianski shouldn't this actually be going to the i2c branch so that #10374 will build or do you intend to rebase the i2c branch once this goes to master ? |
@adbridge Exactly, my intention was to rebase the feature branch after this goes to master. This changes can be helpful in the future, and who knows when the i2c_feature will be merged |
CI started |
Aborted the job unfortunately as we have to reschedule one possibly rc4 PR. |
Test run: FAILEDSummary: 4 of 7 test jobs failed Failed test jobs:
|
Ci restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This PR adds missing DEVICE_I2C guards to I2C hal implementations
These guards are essential when one wants to disable i2c hal implementation for specific targets
Pull request type
Reviewers
@jamesbeyond
@ARMmbed/mbed-os-hal
Release Notes