Skip to content

HAL I2C: adds missing DEVICE_I2C guards #10870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Jun 19, 2019

This PR adds missing DEVICE_I2C guards to I2C hal implementations
These guards are essential when one wants to disable i2c hal implementation for specific targets

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond
@ARMmbed/mbed-os-hal

Release Notes

@ciarmcom
Copy link
Member

@maciejbocianski, thank you for your changes.
@toyowata @maclobdell @ashok-rao @bentcooke @MarceloSalazar @jamesbeyond @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

@maciejbocianski shouldn't this actually be going to the i2c branch so that #10374 will build or do you intend to rebase the i2c branch once this goes to master ?

@maciejbocianski
Copy link
Contributor Author

@adbridge Exactly, my intention was to rebase the feature branch after this goes to master. This changes can be helpful in the future, and who knows when the i2c_feature will be merged

@adbridge
Copy link
Contributor

@adbridge Exactly, my intention was to rebase the feature branch after this goes to master. This changes can be helpful in the future, and who knows when the i2c_feature will be merged

Then you will need to do that rebase in order for #10374 to pass :)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

Aborted the job unfortunately as we have to reschedule one possibly rc4 PR.
We will restart this one once it is in.

@mbed-ci
Copy link

mbed-ci commented Jun 24, 2019

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 1c5909d into ARMmbed:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants