Add support for SPIF of size bigger than 16Mbyte #10779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checks if size is bigger than 16Mbyte - changes to 4 byte address mode of neccessary
|
@martinichka, thank you for your changes. |
VeijoPesonen
reviewed
Jun 7, 2019
VeijoPesonen
reviewed
Jun 7, 2019
components/storage/blockdevice/COMPONENT_SPIF/SPIFBlockDevice.cpp
Outdated
Show resolved
Hide resolved
VeijoPesonen
approved these changes
Jun 7, 2019
VeijoPesonen
reviewed
Jun 7, 2019
components/storage/blockdevice/COMPONENT_SPIF/SPIFBlockDevice.cpp
Outdated
Show resolved
Hide resolved
0xc0170
requested changes
Jun 7, 2019
VeijoPesonen
approved these changes
Jun 10, 2019
0xc0170
approved these changes
Jun 13, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current SPIF Block Devices driver was limited by 16Mbyte due to the 3 byte addressing used. This PR add a check on the size. If bigger than 16M it switches the flash chip to 4 byte address mode.
Pull request type
Reviewers
Release Notes