Default to Cordio BLE stack for NRF52* targets #10709

LDong-Arm · 2019-05-29T15:49:51Z

Description

The BLE stack from SoftDevice is not actively maintained and
has issues (e.g. BLE fails to initialise) when used with Nordic SDK v15.

Note: To verify this PR properly, remove/do not set target-specific labels in mbed_app.json.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng @pan- @paul-szczepanek-arm

Release Notes

Starting with mbed-os 5.13 and the introduction of Nordic SDK V15, Nordic SoftDevice Bluetooth stack is not supported.
Bluetooth remains supported with the help of ARM’s Cordio stack.

paul-szczepanek-arm

cool, in which case remove the mbed json overrides

ciarmcom · 2019-05-29T17:00:48Z

@LDong-Arm, thank you for your changes.
@donatieng @pan- @paul-szczepanek-arm @ARMmbed/mbed-os-maintainers please review.

pan- · 2019-05-30T08:28:09Z

Somehow the BLE feature is not defined for NRF52830 and NRF52840 in targets.json; can you look at that @LDong-Arm ?

LDong-Arm · 2019-05-30T08:47:20Z

Somehow the BLE feature is not defined for NRF52830 and NRF52840 in targets.json; can you look at that @LDong-Arm ?

I thought BLE feature was disabled by default to keep build size down, and only enabled by mbed_app.json as needed? Or should it be enable whenever available?

LDong-Arm · 2019-05-30T10:16:39Z

Somehow the BLE feature is not defined for NRF52830 and NRF52840 in targets.json; can you look at that @LDong-Arm ?

I thought BLE feature was disabled by default to keep build size down, and only enabled by mbed_app.json as needed? Or should it be enable whenever available?

It turns out that SOFTDEVICE_S140's SDK enables BLE, but the CORDIO stack is outside of the SDK so we need to enable BLE in targets.json as discussed with @pan-.

There will be no need to enable BLE again in mbed_app.json of individual applications.

LDong-Arm · 2019-05-30T10:22:07Z

cool, in which case remove the mbed json overrides

Or shall we keep the overrides for compatibility with older mbed-os?

donatieng

Looks good - @ARMmbed/mbed-os-maintainers could this please target RC2?

donatieng · 2019-05-30T13:49:44Z

cool, in which case remove the mbed json overrides

Or shall we keep the overrides for compatibility with older mbed-os?

Please keep them in the examples repo for now until this is on master :)

bulislaw

🎉 Approved for RC2. Should that be documented somewhere? @pan- please add section to release notes in the PR body.

mbed-ci · 2019-06-04T08:38:19Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-06-04T08:46:03Z

Build failures related, one of the tests fails to compile:

        [Error] main.cpp@35,31: use of undeclared identifier '__NRF_NVIC_APP_IRQS_0'
        [Error] main.cpp@35,81: use of undeclared identifier '__NRF_NVIC_APP_IRQS_1'

Please review

Note, rc2 should be finalized today

LDong-Arm · 2019-06-04T09:53:23Z

Build failures related, one of the tests fails to compile:
[Error] main.cpp@35,31: use of undeclared identifier '__NRF_NVIC_APP_IRQS_0'
[Error] main.cpp@35,81: use of undeclared identifier '__NRF_NVIC_APP_IRQS_1'

Please review
Note, rc2 should be finalized today

Thanks for catching that. I've updated the critical section test which failed to build, thanks to help from @pan-

0xc0170 · 2019-06-05T11:36:32Z

Exporters should be OK, but test failed with related errors:

nrf52 ble tests, for ARM:

[1559730685.03][CONN][INF] found KV pair in stream: {{__testcase_name;Test multiple reset commands}}, queued...
[1559730685.03][CONN][INF] found KV pair in stream: {{__testcase_start;Test reset command}}, queued...
[1559730685.13][CONN][RXD] ++ MbedOS Error Info ++
[1559730685.13][CONN][RXD] Error Status: 0x80010133 Code: 307 Module: 1
[1559730685.23][CONN][RXD] Error Message: Mutex: 0x200078AC, Not allowed in ISR context

same test fails also for GCC/IAR but has test assert rather. Anyway, same test (features-feature_ble-targets-target_cordio-tests-cordio_hci-transport) 3 compilers , nrf52 target

0xc0170 · 2019-06-05T12:20:05Z

Moved to rc3, rc2 generated

LDong-Arm · 2019-06-06T09:30:53Z

Exporters should be OK, but test failed with related errors:
nrf52 ble tests, for ARM:
[1559730685.03][CONN][INF] found KV pair in stream: {{__testcase_name;Test multiple reset commands}}, queued...
[1559730685.03][CONN][INF] found KV pair in stream: {{__testcase_start;Test reset command}}, queued...
[1559730685.13][CONN][RXD] ++ MbedOS Error Info ++
[1559730685.13][CONN][RXD] Error Status: 0x80010133 Code: 307 Module: 1
[1559730685.23][CONN][RXD] Error Message: Mutex: 0x200078AC, Not allowed in ISR context

same test fails also for GCC/IAR but has test assert rather. Anyway, same test (features-feature_ble-targets-target_cordio-tests-cordio_hci-transport) 3 compilers , nrf52 target

I can locally reproduce this issue. Looking into it.

0xc0170 · 2019-06-07T08:02:57Z

@LDong-Arm Any update, just any timebox for this - we would like to timebox rc3

paul-szczepanek-arm · 2019-06-07T08:14:49Z

I've got a fix for that one, working on it. Give me an a few hours. Doesn't mean there won't be more

disable test

0xc0170 · 2019-06-07T14:12:04Z

CI started

mbed-ci · 2019-06-07T16:42:21Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

CodingGhost · 2019-08-07T11:37:51Z

Hi, I just read about the cordio stack, but I hthink(hope) I misunderstood something.
will the nordic softdevice and SDK15 still be supported/functional with the latest release?
because as I understood it, the S140 is replaced by cordio, which means that everything that I did in the last years is now useless and deprecated..?

pan- · 2019-08-07T14:49:21Z

SDK15 is still supported and functional while soft device is no more in the latest release.
The BLE API is still supported and will continue to be. However it got a different implementation based on the Cordio stack and not the softdevice.

It would be interesting for us to understand what limitation/issues you would hit updating your software to the laster release.

Please note that the nordic SDK and the softdevice have never been part of mbed-os public API. Those are implementation details.

CodingGhost · 2019-08-08T11:28:39Z

ok, thats good, but I see one problem for me. I currently use the softdevice for OTA updates with the Nordic DFU service, so if I use cordio instead of the S140, I cannot use my bootloader anymore right?

also, I am using some direct calls to the nordic SD, for example to go into deep sleep powerdown mode, how would I do this then?

CodingGhost · 2019-08-15T12:10:39Z

@pan- so what about my problems?

BracketJohn · 2019-08-16T15:38:32Z

@pan- I'm also interested in whether DFU will still work with the new Cordio stack, as I'm looking to perform BLE OTA DFUs.

An answer here would be greatly appreciated!

0Grit · 2019-08-16T15:44:53Z

@BracketJohn there are a couple issues regarding your question. Can't remember if they are still open.

BracketJohn · 2019-08-16T15:48:12Z

Hi @loverdeg-ep, thanks for the reply! So far, I found #3363, #4587 and #5412, but all of them are closed or inactive it seems. Also, I was not able to find any updated guides/statements on this issue, do you know whether there was an answer somewhere?

Edit: I also found this mbed forum thread from 4 months ago, that said that this feature is high priority and still in planing: https://os.mbed.com/questions/85333/Arm-Mbed-Cordio-and-OTA-DFU/

I've created #11251 to get some clarity on this.

pan- · 2019-08-19T10:31:18Z

@donatieng Could you comment on DFU over BLE using the Cordio stack ?

BracketJohn · 2019-08-19T10:40:18Z

@donatieng, @pan- I've also created #11251 in order to get a more visible answer on this – I've also listed some of the issues on the topic I found there, maybe that helps/is a good place to answer the question

paul-szczepanek-arm approved these changes May 29, 2019

View reviewed changes

pan- approved these changes May 29, 2019

View reviewed changes

ciarmcom requested review from donatieng, pan-, paul-szczepanek-arm and a team May 29, 2019 17:00

ciarmcom added the needs: review label May 29, 2019

LDong-Arm force-pushed the nrf52_cordio branch from eddf7c5 to b468802 Compare May 30, 2019 10:18

donatieng approved these changes May 30, 2019

View reviewed changes

pan- approved these changes May 30, 2019

View reviewed changes

paul-szczepanek-arm approved these changes Jun 3, 2019

View reviewed changes

0xc0170 added the release-version: 5.13.0-rc2 label Jun 3, 2019

0xc0170 approved these changes Jun 3, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jun 3, 2019

bulislaw approved these changes Jun 4, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Jun 4, 2019

LDong-Arm force-pushed the nrf52_cordio branch from b468802 to ba84805 Compare June 4, 2019 09:50

0xc0170 added needs: CI and removed needs: work labels Jun 4, 2019

0xc0170 added needs: work and removed needs: CI labels Jun 5, 2019

adbridge added release-version: 5.13.0-rc3 and removed release-version: 5.13.0-rc2 labels Jun 5, 2019

LDong-Arm mentioned this pull request Jun 6, 2019

Workarounds for GAP advertising issues on Cordio #10772

Merged

paul-szczepanek-arm and others added 2 commits June 7, 2019 13:50

exculde test

1fe06f1

Merge pull request #1 from paul-szczepanek-arm/nrf52_cordio

3307c59

disable test

0xc0170 added needs: CI and removed needs: work labels Jun 7, 2019

0xc0170 added ready for merge and removed needs: CI labels Jun 9, 2019

0xc0170 merged commit dc77c40 into ARMmbed:master Jun 9, 2019

0xc0170 removed the ready for merge label Jun 9, 2019

BracketJohn mentioned this pull request Aug 16, 2019

nRF52 BLE OTA DFUs in mbed OS >=5.13 #11251

Closed

Default to Cordio BLE stack for NRF52* targets #10709

Default to Cordio BLE stack for NRF52* targets #10709

Uh oh!

Conversation

LDong-Arm commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

Uh oh!

ciarmcom commented May 29, 2019

Uh oh!

pan- commented May 30, 2019

Uh oh!

LDong-Arm commented May 30, 2019

Uh oh!

LDong-Arm commented May 30, 2019

Uh oh!

LDong-Arm commented May 30, 2019

Uh oh!

donatieng left a comment

Choose a reason for hiding this comment

Uh oh!

donatieng commented May 30, 2019

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jun 4, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LDong-Arm commented Jun 4, 2019

Uh oh!

0xc0170 commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jun 5, 2019

Uh oh!

LDong-Arm commented Jun 6, 2019

Uh oh!

0xc0170 commented Jun 7, 2019

Uh oh!

paul-szczepanek-arm commented Jun 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jun 7, 2019

Uh oh!

mbed-ci commented Jun 7, 2019

Test run: SUCCESS

Uh oh!

CodingGhost commented Aug 7, 2019

Uh oh!

pan- commented Aug 7, 2019

Uh oh!

CodingGhost commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CodingGhost commented Aug 15, 2019

Uh oh!

BracketJohn commented Aug 16, 2019

Uh oh!

0Grit commented Aug 16, 2019

Uh oh!

BracketJohn commented Aug 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pan- commented Aug 19, 2019

Uh oh!

BracketJohn commented Aug 19, 2019

Uh oh!

Uh oh!

LDong-Arm commented May 29, 2019 •

edited

Loading

0xc0170 commented Jun 4, 2019 •

edited

Loading

0xc0170 commented Jun 5, 2019 •

edited

Loading

paul-szczepanek-arm commented Jun 7, 2019 •

edited

Loading

CodingGhost commented Aug 8, 2019 •

edited

Loading

BracketJohn commented Aug 16, 2019 •

edited

Loading