MbedCRC: make buffers const void * #10699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first PR to Mbed OS as a member of the Core & Platform team, testing the waters. Let me know if I missed anything, as we had a different process before in Update Client. |
|
@loverdeg-ep |
|
@gpsimenos, thank you for your changes. |
kjbracey
reviewed
May 29, 2019
kjbracey
approved these changes
Jun 3, 2019
0xc0170
approved these changes
Jun 3, 2019
|
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In MbedCRC, changing the following buffers from void * to const void *:
int32_t compute(const void *buffer, crc_data_size_t size, uint32_t *crc)
int32_t compute_partial(const void *buffer, crc_data_size_t size, uint32_t *crc)
This addresses issue #8287 (IOTCORE-556)
Pull request type
Reviewers
Release Notes