Skip to content

STM32: common cmsis.h and device.h files #10676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

STM32: common cmsis.h and device.h files #10676

merged 1 commit into from
May 31, 2019

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented May 27, 2019 •
edited by 0xc0170
Loading

Description

Hi

  • cmsis.h file was present for each target, but is common within the same STM32 family
  • device.h file was present for each STM32 family, but is common for all STM32

There should be no impact with this PR,
goal is only for maintenance activity.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team May 27, 2019 09:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team May 27, 2019 12:29
LMESTM
LMESTM reviewed May 27, 2019
View reviewed changes
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on the code factoring - few comments though

targets/TARGET_STM/device.h Outdated
@@ -2,7 +2,7 @@
// Check the 'features' section of the target description in 'targets.json' for more details.
/* mbed Microcontroller Library
*******************************************************************************
* Copyright (c) 2015, STMicroelectronics
* Copyright (c) 2014, STMicroelectronics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not the most recent file was used

targets/TARGET_STM/TARGET_STM32WB/cmsis.h Outdated
#ifndef MBED_CMSIS_H
#define MBED_CMSIS_H

#include "stm32wbxx.h"
#include "cmsis_nvic.h"

#include "stm32wbxx_ll_usart.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem the right place to include .. maybe to be checked if can be included from object.h ?

@jeromecoutant
Copy link
Collaborator Author

@LMESTM I agree with comments.
Could you check the new version ?

LMESTM
LMESTM approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7ebadbf into ARMmbed:master May 31, 2019
@jeromecoutant jeromecoutant deleted the PR_COMMON_CMSIS branch June 3, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LMESTM LMESTM LMESTM approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @LMESTM