Skip to content

Replace uses of ArrayView with mbed::Span #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Replace uses of ArrayView with mbed::Span #10659

merged 2 commits into from
Jun 18, 2019

Conversation

LDong-Arm
Copy link
Contributor

Description

The public API Span provides the same features as ArrayView (internal to BLE). There's no point to maintain the latter.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan- @paul-szczepanek-arm

pan-
pan- approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Thanks @LDong-Arm

LDong-Arm
LDong-Arm commented May 24, 2019
View reviewed changes
@ciarmcom ciarmcom requested review from pan-, paul-szczepanek-arm and a team May 24, 2019 13:00
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@pan- @paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@LDong-Arm LDong-Arm force-pushed the replace_ArrayView branch from 39bf7bd to 2baa3c9 Compare May 29, 2019 13:04
@LDong-Arm LDong-Arm force-pushed the replace_ArrayView branch from 2baa3c9 to 37d13d9 Compare June 7, 2019 13:35
ithinuel
ithinuel approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that the changes are covered by some tests it LGTM.

LDong-Arm
LDong-Arm commented Jun 7, 2019
View reviewed changes
LDong-Arm added 2 commits June 7, 2019 16:18
@LDong-Arm
BLE: Replace uses of ArrayView with mbed::Span
6f7f133 
The platform API mbed::Span provides the same features as ArrayView.
@LDong-Arm
Remove ArrayView
7426a8a 
All use of ArrayView within mbed-os have been removed, and
it is not a public API.
@LDong-Arm LDong-Arm force-pushed the replace_ArrayView branch from 37d13d9 to 7426a8a Compare June 7, 2019 15:19
@pan-
Copy link
Member

pan- commented Jun 13, 2019

@0xc0170 What's missing for this PR to be tested ?

paul-szczepanek-arm
paul-szczepanek-arm approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, merge

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 13, 2019

We will schedule CI once rc3 is out, all needs: CI should get in

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

Lots of random failures over the weekend. Restarting CI.

@mbed-ci
Copy link

mbed-ci commented Jun 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

CI restarted after smart tester fixes

@mbed-ci
Copy link

mbed-ci commented Jun 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@LDong-Arm
Copy link
Contributor Author

Looking into the artifacts, there seems to be greentea failures on EV_COG_AD3029LZ and NUCLEO_F429ZI. I'll try to reproduce the issues locally.

@LDong-Arm
Copy link
Contributor Author

The EV_COG_AD3029LZ failure is an assertion failure and I'll try to reproduce it.

All NUCLEO_F429Z failures have

[HTST][ERR] remote write error: Write response(request_id: ...) timeout!

(I removed the request_id.) @adbridge It looks like an issue with the CI?

@adbridge adbridge merged commit 46be526 into ARMmbed:master Jun 18, 2019
@LDong-Arm LDong-Arm deleted the replace_ArrayView branch June 18, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@ithinuel ithinuel ithinuel approved these changes

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LDong-Arm @ciarmcom @pan- @0xc0170 @adbridge @mbed-ci @ithinuel @paul-szczepanek-arm