Skip to content

STM USBHALHost: Fix NULL pointer dereference #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2019
Merged

STM USBHALHost: Fix NULL pointer dereference #10653

merged 2 commits into from
Jun 9, 2019
+7 −3

Conversation

desowin
Copy link
Contributor

@desowin desowin commented May 24, 2019

Description

On STM32F746G Discovery boards, the USB OTG HS port does not have a
dedicated GPIO for controlling the USB VBUS.

This change fixes HardFault (NULL pointer dereference) that triggered
when such USB host port was used.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desowin
STM USBHALHost: Fix NULL pointer dereference
f5527ea 
On STM32F746G Discovery boards, the USB OTG HS port does not have a
dedicated GPIO for controlling the USB VBUS.

This change fixes HardFault (NULL pointer dereference) that triggered
when such USB host port was used.
@ciarmcom ciarmcom requested a review from a team May 24, 2019 11:00
@ciarmcom
Copy link
Member

@desowin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

CI started

Note, we have new USB stack that should be used. This PR touches the old unsupported one.

@desowin
Copy link
Contributor Author

desowin commented May 31, 2019

Note, we have new USB stack that should be used. This PR touches the old unsupported one.

I know about the USB device stack that is supported. However, is there a new USB host stack? If there is, then I must have missed it.

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019 •
edited
Loading

CI restarted

I quickly fixed the coding style (keep it consistent)

@mbed-ci
Copy link

mbed-ci commented Jun 3, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@desowin desowin mentioned this pull request Jun 3, 2019
Closed
@cmonr
Copy link
Contributor

cmonr commented Jun 3, 2019

CI restarted. S3 issues appear addressed.

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019 •
edited
Loading

we will restart tests once 5.13rc2 is completed (failures above not related to the changeset)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit df84eb1 into ARMmbed:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@desowin @ciarmcom @0xc0170 @mbed-ci @cmonr @adbridge