BLE: deprecate UARTService and suppress compiler warnings #10635
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UARTService is rarely used and has not been actively updated.
8f7188b to
d10ec03
Compare
paul-szczepanek-arm
approved these changes
May 22, 2019
|
@LDong-Arm, thank you for your changes. |
pan-
requested changes
May 23, 2019
Thanks, will do |
Services that already have deprecation notices in place should not trigger more warnings from the compiler.
d10ec03 to
f3c29df
Compare
0xc0170
reviewed
May 23, 2019
|
@0xc0170 This service hasn't been maintained for a long time (more than three years) and never really worked due to architectural defects (there's no flow control and we don't know when data flows out). I believe it is better to deprecate it now rather than leave the false impression it is useful and safe to use. It was a bad decision to land this code in the OS in the first place. |
pan-
approved these changes
May 23, 2019
0xc0170
approved these changes
May 23, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecated BLE APIs called by deprecated services
We have already marked a few services (e.g. ones for Beacon) as deprecated, thus their uses of deprecated API should not lead to more compiler warnings.
UARTService
UARTService uses the old GAP advertising API which is now deprecated in favour of AdvertisingDataBuilder.
After discussing with @pan- @paul-szczepanek-arm, we consider deprecating UARTService.
Pull request type
Reviewers
@pan- @paul-szczepanek-arm