Add Wi-Sun certificate options to mesh api configuration json #10598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added possibility to configure Wi-Sun root certificate, own certificate and own certificate keys to mesh api.
|
@mikaleppanen, thank you for your changes. |
SeppoTakalo
approved these changes
May 16, 2019
SeppoTakalo
suggested changes
May 16, 2019
| @@ -153,6 +153,22 @@ | |||
| "wisun-uc-dwell-interval": { | |||
| "help": "Unicast dwell interval. Range: 15-255 milliseconds", | |||
| "value": 0 | |||
| }, | |||
| "certificate-header": { | |||
| "help": "Certificate header", | |||
There was a problem hiding this comment.
What is the type or range of the value field? Please document that as well.
Others have already documentation.
artokin
reviewed
May 16, 2019
| arm_certificate_chain_entry_s chain_info; | ||
| memset(&chain_info, 0, sizeof(arm_certificate_chain_entry_s)); | ||
| chain_info.cert_chain[0] = (const uint8_t *) MBED_CONF_MBED_MESH_API_ROOT_CERTIFICATE; | ||
| chain_info.cert_len[0] = strlen((const char *) MBED_CONF_MBED_MESH_API_ROOT_CERTIFICATE) + 1; |
There was a problem hiding this comment.
Could you check configuration validity at compile time to avoid hard fault caused by illegal configuration?
|
@artokin @SeppoTakalo Updated pull request according to comments. |
SeppoTakalo
approved these changes
May 17, 2019
mikter
approved these changes
May 20, 2019
0xc0170
approved these changes
May 20, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add possibility to configure Wi-Sun root certificate, own certificate
and own certificate keys to mesh api.
Pull request type
Reviewers
@mikter