Skip to content

Cellular: fixed compile warnings from cellular #10554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

Cellular: fixed compile warnings from cellular #10554

merged 1 commit into from
May 17, 2019

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented May 10, 2019

Description

Removed compile warnings from cellular to clean up the compile.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

@ciarmcom ciarmcom requested review from mirelachirica and a team May 10, 2019 07:00
@ciarmcom
Copy link
Member

@jarvte, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as it is, for future reference: It would be helpful to provide what warnings are being fixed

@0xc0170
Copy link
Contributor

0xc0170 commented May 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 13, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented May 13, 2019

Please review build failures, related to these changes

@jarvte jarvte force-pushed the remove_compile_warnings branch from 24b1a9f to d56c8ca Compare May 14, 2019 05:48
@jarvte
Copy link
Contributor Author

jarvte commented May 14, 2019

amended compile error fixes

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented May 16, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge merged commit 25019df into ARMmbed:master May 17, 2019
@adbridge
Copy link
Contributor

There is something strange, conflict wise, with both this and the related #10557 and neither will patch across to 5.12. Thus bumping to 5.13.

@jarvte jarvte deleted the remove_compile_warnings branch May 21, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

@kivaisan kivaisan kivaisan approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jarvte @ciarmcom @0xc0170 @mbed-ci @adbridge @mirelachirica @kivaisan