Skip to content

Cellular: Fix setting of statemachine timeout #10511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019

Conversation

AriParkkila
Copy link

Description

Fix setting of cellular statemachine timeout.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan @jarvte @AnttiKauppila

Release Notes

@ciarmcom ciarmcom requested review from AnttiKauppila, jarvte, kivaisan and a team April 30, 2019 09:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@AnttiKauppila @jarvte @kivaisan @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@AriParkkila AriParkkila force-pushed the cell-statemachine-timeout branch from d539b07 to 6740c32 Compare April 30, 2019 09:31
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal change , fine for the patch release as fix?

@adbridge
Copy link
Contributor

adbridge commented May 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 7, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@AriParkkila AriParkkila force-pushed the cell-statemachine-timeout branch from 6740c32 to 830b423 Compare May 9, 2019 11:43
@AriParkkila
Copy link
Author

Rebased and updated unittests, so it should be ready for merge.

@0xc0170
Copy link
Contributor

0xc0170 commented May 12, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented May 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge
Copy link
Contributor

This is on top of changes for 5.13 so will also need to go to that release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants