Skip to content

UDPSOCKET_ECHOTEST fails if a packet of every size was not sent #10426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

michalpasztamobica
Copy link
Contributor

Description

So far the UDPSOCKET_ECHOTEST could report success if no packets were sent. The only trace of problems was visible in the logs.
It could also report pass if the device was able to send a lot of small packets, but consistently failed with larger ones.
We want to make sure that at least one packet of every size gets sent at least once, so we check if the number of sent packets increased after every loop (it can increase by 1, 2 or 3, depending on how many times the retry loop executes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen

@ciarmcom ciarmcom requested review from SeppoTakalo, VeijoPesonen and a team April 17, 2019 07:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@VeijoPesonen @SeppoTakalo @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@michalpasztamobica
Copy link
Contributor Author

@0xc0170 , is there some CI issue or something wrong with my code or PR?

10:03:32 Scheduling project: mbed-os-ci_build-ARM
Aborted by Martin Kojtal

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2019

Aborted build, we need CI time for 5.12.2 jobs today. this needs reviews first - it was run by CI trigger, it's now disabled, need manual control for now.

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mentioned also in the test specifications to avoid confusion

@michalpasztamobica
Copy link
Contributor Author

@VeijoPesonen , I amended the documentation, including the sentence on recvfrom(), to express how the test really works.

@adbridge
Copy link
Contributor

ci started

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@michalpasztamobica
Copy link
Contributor Author

The greentea failures are in K66F block storage tests.They are in no way related to my changes. I restarted the greentea job.

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , your review would be much appreciated :)

@adbridge adbridge merged commit a5f1a12 into ARMmbed:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants