-
Notifications
You must be signed in to change notification settings - Fork 3k
UDPSOCKET_ECHOTEST fails if a packet of every size was not sent #10426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UDPSOCKET_ECHOTEST fails if a packet of every size was not sent #10426
Conversation
34d3a42
to
e3c9f3e
Compare
@michalpasztamobica, thank you for your changes. |
e3c9f3e
to
e11fade
Compare
Test run: FAILEDSummary: 3 of 3 test jobs failed Failed test jobs:
|
@0xc0170 , is there some CI issue or something wrong with my code or PR?
|
Aborted build, we need CI time for 5.12.2 jobs today. this needs reviews first - it was run by CI trigger, it's now disabled, need manual control for now. |
Test run: FAILEDSummary: 3 of 3 test jobs failed Failed test jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be mentioned also in the test specifications to avoid confusion
e11fade
to
46ee10f
Compare
46ee10f
to
d1017ea
Compare
@VeijoPesonen , I amended the documentation, including the sentence on recvfrom(), to express how the test really works. |
ci started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
The greentea failures are in K66F block storage tests.They are in no way related to my changes. I restarted the greentea job. |
@SeppoTakalo , your review would be much appreciated :) |
Description
So far the UDPSOCKET_ECHOTEST could report success if no packets were sent. The only trace of problems was visible in the logs.
It could also report pass if the device was able to send a lot of small packets, but consistently failed with larger ones.
We want to make sure that at least one packet of every size gets sent at least once, so we check if the number of sent packets increased after every loop (it can increase by 1, 2 or 3, depending on how many times the retry loop executes.
Pull request type
Reviewers
@SeppoTakalo
@VeijoPesonen