-
Notifications
You must be signed in to change notification settings - Fork 3k
Clean up ARM toolchains from get_mbed_official_release() #10398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously it would return "ARM" for "ARMC5", which was quite confusing.
@bridadan, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
As this is refactor, will go into 5.13 (let us know if this is not the case) |
CI started |
Test run: FAILEDSummary: 4 of 7 test jobs failed Failed test jobs:
|
restarted CI |
This pr in its current form does break the current assumptions in the CI, which is why no targets were built with ARM toolchains. |
Will wait for CI update |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
CI updated. |
CI restarted (rebuild) |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage |
ci started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
@bridadan please take a look at the test failures |
@adbridge looks like some uvision6 jobs timed out. Does that mean it needs to be restarted? |
ci restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Restarted cloud-client-test |
Previously it would return
ARM
forARMC5
, which was quite confusing, since supplying-t ARM
will select eitherARMC5
orARMC6
internally. Now it will returnARMC5
if the targets only supportsARMC5
,ARMC5
andARMC6
if it supports both, or justARMC6
if it only supportsARMC6
.Description
Pull request type
Reviewers
@OPpuolitaival - I'd like to double check with you that this won't cause issues or break assumptions in the CI
Release Notes