Skip to content

Clean up ARM toolchains from get_mbed_official_release() #10398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

bridadan
Copy link
Contributor

Previously it would return ARM for ARMC5, which was quite confusing, since supplying -t ARM will select either ARMC5 or ARMC6 internally. Now it will return ARMC5 if the targets only supports ARMC5, ARMC5 and ARMC6 if it supports both, or just ARMC6 if it only supports ARMC6.

Description

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival - I'd like to double check with you that this won't cause issues or break assumptions in the CI

Release Notes

Previously it would return "ARM" for "ARMC5", which was quite confusing.
@ciarmcom ciarmcom requested review from OPpuolitaival and a team April 12, 2019 21:00
@ciarmcom
Copy link
Member

@bridadan, thank you for your changes.
@OPpuolitaival @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

@OPpuolitaival - I'd like to double check with you that this won't cause issues or break assumptions in the CI

As this is refactor, will go into 5.13 (let us know if this is not the case)

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@alekla01
Copy link
Contributor

restarted CI

@alekla01
Copy link
Contributor

This pr in its current form does break the current assumptions in the CI, which is why no targets were built with ARM toolchains.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

This pr in its current form does break the current assumptions in the CI, which is why no targets were built with ARM toolchains.

Will wait for CI update

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@alekla01
Copy link
Contributor

CI updated.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

CI restarted (rebuild)

@mbed-ci
Copy link

mbed-ci commented Apr 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@alekla01
Copy link
Contributor

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@adbridge
Copy link
Contributor

ci started

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@adbridge
Copy link
Contributor

@bridadan please take a look at the test failures

@bridadan
Copy link
Contributor Author

@adbridge looks like some uvision6 jobs timed out. Does that mean it needs to be restarted?

@adbridge
Copy link
Contributor

ci restarted

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@alekla01
Copy link
Contributor

Restarted cloud-client-test

@0xc0170 0xc0170 merged commit 39699d5 into ARMmbed:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants