Skip to content

GigaDevice: Cortex-M4 -> Cortex-M4F #10383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

kjbracey
Copy link
Contributor

Description

GigaDevice parts have FPU - change core in targets.json to use it.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

GigaDevice parts have FPU - change core in targets.json to use it.
@ciarmcom ciarmcom requested a review from a team April 12, 2019 09:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2019

cc @ChazJin - please review

@ChazJin
Copy link
Contributor

ChazJin commented Apr 16, 2019

@kjbracey-arm, thank you for your changes, and it looks good to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

CI will restart, the exporter failure is license issue

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 6c40386 into ARMmbed:master Apr 17, 2019
@kjbracey kjbracey deleted the add_fpu_gd32 branch April 17, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants