Skip to content

Updated AWS url for astyle. #10275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Updated AWS url for astyle. #10275

merged 1 commit into from
Apr 1, 2019

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Mar 29, 2019

Description

The old AWS url is no longer appropriate for storing the astyle archive.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@cmonr cmonr requested review from a team March 29, 2019 16:02
adbridge
adbridge approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT looks ok to me

@cmonr
Copy link
Contributor Author

cmonr commented Mar 29, 2019

Was originally intending to update the URL with the Travis CI update, but I guess I was a bit optimistic on the review speed for that PR: https://github.com/ARMmbed/mbed-os/pull/9844/files

@cmonr cmonr mentioned this pull request Mar 29, 2019
Merged
@cmonr
Updated AWS url for astyle.
6c9c7f1 
The original one is no longer appropriate
@cmonr cmonr force-pushed the switch-aws-bucket branch from 99fbc33 to 6c9c7f1 Compare March 29, 2019 17:18
@cmonr
Copy link
Contributor Author

cmonr commented Mar 29, 2019

CI started

@NirSonnenschein
Copy link
Contributor

@cmonr I'm confused, is this ready or does it need further review?

@cmonr
Copy link
Contributor Author

cmonr commented Apr 1, 2019

Whoops.

@NirSonnenschein It's ready, but needs a final OK from @ARMmbed/mbed-os-test-team (mainly @OPpuolitaival )

@OPpuolitaival
Copy link
Contributor

Both seems to be valid urls for now

@NirSonnenschein
Copy link
Contributor

starting CI

@0xc0170 0xc0170 merged commit 333da46 into ARMmbed:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmonr @NirSonnenschein @OPpuolitaival @0xc0170 @adbridge