Nanostack ARMC6 update #10231
Merged
Nanostack ARMC6 update #10231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2019 13:19
…e7ba 086e7ba Adjust variable scope (ARMmbed#121) git-subtree-dir: features/nanostack/coap-service git-subtree-split: 086e7ba
Fix compiler warnings: -"warning: 'size' argument to memset is '0'" -"warning: implicit declaration of function"
JarkkoPaso
approved these changes
Mar 26, 2019
|
@artokin, thank you for your changes. |
SeppoTakalo
approved these changes
Mar 26, 2019
cmonr
approved these changes
Mar 26, 2019
| @@ -70,7 +71,7 @@ static fhss_timeout_s *allocate_timeout(void) | |||
| { | |||
| for (int i = 0; i < NUMBER_OF_SIMULTANEOUS_TIMEOUTS; i++) { | |||
| if (fhss_timeout[i].fhss_timer_callback == NULL) { | |||
| memset(&fhss_timeout[i], sizeof(fhss_timeout_s), 0); | |||
| memset(&fhss_timeout[i], 0, sizeof(fhss_timeout_s)); | |||
| @@ -19,6 +19,12 @@ | |||
|
|
|||
| #include "mbedtls/entropy_poll.h" | |||
|
|
|||
| #ifdef MBEDTLS_ENTROPY_HARDWARE_ALT | |||
There was a problem hiding this comment.
Feels weird to have both an ifdef and if defined in the same line.
There was a problem hiding this comment.
Won't hold this up on that nit tho.
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
|
@ARMmbed/mbed-os-mesh Any thoughts? |
mikter
approved these changes
Mar 28, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 28, 2019
Nanostack ARMC6 update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request type
Reviewers
@JarkkoPaso , @mikter , @deepakvenugopal